Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude logging dependency of pulsar library #157

Merged
merged 2 commits into from
Aug 24, 2023

Conversation

chaoqin-li1123
Copy link
Contributor

@chaoqin-li1123 chaoqin-li1123 commented Aug 23, 2023

Motivation

Exclude slf4j and log4j library of pulsar dependency because it conflicts with the slf4j and log4j library of spark 3.4

Modifications

Exclude slf4j and log4j library of pulsar dependency.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

  • This change is a trivial rework / code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:

  • This change added tests and can be verified as follows:

Documentation

Check the box below.

Need to update docs?

  • doc-required
  • no-need-doc
  • doc

@chaoqin-li1123 chaoqin-li1123 requested review from nlu90 and a team as code owners August 23, 2023 19:59
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Aug 23, 2023
@nlu90 nlu90 merged commit a07d445 into streamnative:master Aug 24, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants