Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed remove auth plugin suffix #1084

Merged
merged 2 commits into from May 29, 2023
Merged

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented May 29, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions
Copy link

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels May 29, 2023
@github-actions
Copy link

@tuteng:Thanks for providing doc info!

@github-actions github-actions bot added the doc-required This pr needs a document label May 29, 2023
@github-actions
Copy link

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-required This pr needs a document doc-info-missing This pr needs to mark a document option in description labels May 29, 2023
@github-actions
Copy link

@tuteng:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label May 29, 2023
@tuteng tuteng merged commit 1ce4fc0 into master May 29, 2023
16 checks passed
@tuteng tuteng deleted the fixed/remove-authplugin-suffix branch May 29, 2023 08:13
tuteng added a commit that referenced this pull request May 29, 2023
* Fixed auth plugin suffix

(cherry picked from commit 1ce4fc0)
tuteng added a commit that referenced this pull request May 29, 2023
* Fixed auth plugin suffix

(cherry picked from commit 1ce4fc0)
tuteng added a commit that referenced this pull request May 29, 2023
* Fixed auth plugin suffix

(cherry picked from commit 1ce4fc0)
tuteng added a commit that referenced this pull request May 29, 2023
* Fixed auth plugin suffix

(cherry picked from commit 1ce4fc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants