Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support status check for pulsarctl command #1200

Merged
merged 8 commits into from Sep 8, 2023

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Sep 8, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  • Support status check for pulsarctl command
  • Support read config from env

How to use it:

export PULSAR_CLIENT_FROM_ENV=true
export webServiceUrl=http://localhost:8080
export authParams=xxxx
export authPlugin=xxxxxxx
pulsarctl status check

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 8, 2023
@tuteng tuteng added doc-required This pr needs a document and removed doc-info-missing This pr needs to mark a document option in description labels Sep 8, 2023
mattisonchao
mattisonchao previously approved these changes Sep 8, 2023
@tuteng tuteng removed the doc-required This pr needs a document label Sep 8, 2023
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Sep 8, 2023
@tuteng tuteng merged commit be22457 into master Sep 8, 2023
12 checks passed
@tuteng tuteng deleted the feature/support-status-check branch September 8, 2023 12:38
tuteng added a commit that referenced this pull request Sep 11, 2023
* Support read config from env
* Add site toc content

(cherry picked from commit be22457)
tuteng added a commit that referenced this pull request Sep 11, 2023
* Support read config from env
* Add site toc content

(cherry picked from commit be22457)
tuteng added a commit that referenced this pull request Sep 11, 2023
* Support read config from env
* Add site toc content

(cherry picked from commit be22457)
tuteng added a commit that referenced this pull request Sep 11, 2023
* Support read config from env
* Add site toc content

(cherry picked from commit be22457)
tuteng added a commit that referenced this pull request Sep 11, 2023
* Support status check for pulsarctl command (#1200)

* Support read config from env
* Add site toc content

(cherry picked from commit be22457)

* Migrate pulsar-admin-go to apache pulsar client go (#1170)

(cherry picked from commit 811717e)

Replace streamnative admin go repo use apache admin go repo
tuteng added a commit that referenced this pull request Sep 22, 2023
* Support status check for pulsarctl command (#1200)

* Support read config from env
* Add site toc content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants