Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth SN docker hub #1398

Merged
merged 1 commit into from Mar 21, 2024
Merged

Auth SN docker hub #1398

merged 1 commit into from Mar 21, 2024

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Mar 21, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Mar 21, 2024
@coderzc coderzc merged commit cadee81 into master Mar 21, 2024
12 checks passed
@coderzc coderzc deleted the auth_dockerhub branch March 21, 2024 13:58
coderzc added a commit that referenced this pull request Mar 21, 2024
(cherry picked from commit cadee81)
coderzc added a commit that referenced this pull request Mar 21, 2024
(cherry picked from commit cadee81)
coderzc added a commit that referenced this pull request Mar 21, 2024
(cherry picked from commit cadee81)
yaalsn pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants