Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(dht): Test WebSocket client recovery #2084

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(dht): Test WebSocket client recovery #2084

wants to merge 1 commit into from

Conversation

mondoreale
Copy link
Contributor

Summary

Test the WebSocket client recovery in 3 scenarios:

  • Normal hiccup where the WebSocket connection closes randomly between sending messages.
  • Pre-handshake failure where the WebSocket connection closes right after getting up.
  • Pre-handshake failure where the WebSocket connection fails to get up at first attempt.

The aim is to make sure further messages are capable of reestablishing the lost connection.

@github-actions github-actions bot added the dht Related to DHT package label Nov 20, 2023
@mondoreale
Copy link
Contributor Author

Will fix that validation step shortly!

@mondoreale mondoreale force-pushed the dht-ws-client-recovery-tests branch 3 times, most recently from 97c9b41 to 8ac65ae Compare November 20, 2023 14:51
@mondoreale
Copy link
Contributor Author

The new tests are green but it looks like other things "dht" do fail now.

@mondoreale mondoreale force-pushed the dht-ws-client-recovery-tests branch 2 times, most recently from 952668e to 46ca2d1 Compare November 22, 2023 11:08
@mondoreale
Copy link
Contributor Author

Moved it to unit tests.

Base automatically changed from streamr-1.0 to main December 27, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptesavol ptesavol Awaiting requested review from ptesavol

@juslesan juslesan Awaiting requested review from juslesan

Assignees
No one assigned
Labels
dht Related to DHT package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mondoreale