fix(dht): Self-connection guards in DhtNode
#2123
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we receive
connection
event from transport, we have been checking if the connection is from this node. We check that fact both when we receiveconnected
event fromITransport
, and when we query the initial connections.If the connection is from this node we now return from the methods and don't update the
connections
state.This is a cherry-pick from #1803, i.e. the original author is @ptesavol.
Open question