streamr-1.0 fix-start-and-stop-of-autocertifier-client #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teogeb
requested changes
Dec 8, 2023
| @@ -36,7 +36,6 @@ export interface IAutoCertifierClient { | |||
| stop(): void | |||
| on(eventName: string, cb: (subdomain: CertifiedSubdomain) => void): void | |||
| } | |||
|
|
|||
| const requests = Array.from(this.ongoingConnectRequests.values()) | ||
| await Promise.allSettled(requests.map((conn) => conn.close(false))) | ||
| if (this.autoCertifierClient) { | ||
| await this.autoCertifierClient.stop() |
There was a problem hiding this comment.
Suggested change
| await this.autoCertifierClient.stop() | |
| this.autoCertifierClient.stop() |
| // all paths of this.autoCertifierClient.start() will block until 'updatedCertificate' | ||
| // event is emitted or an exception is thrown | ||
|
|
||
| await withTimeout(this.autoCertifierClient.start(), START_TIMEOUT, |
There was a problem hiding this comment.
Maybe we should separate the starting of the client and obtaining the initial certificate. It doesn't take long time to start the client, but in practice we wait for the certificate?
Also could rename AutoCertifierClientFacade to AutoCertifierFacade as we don't seem to use any of the client's functionality methods (we just call the start and stop methods).
-> maybe in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix-start-and-stop-of-autocertifier-client pull request moved to base upon streamr-1.0 instead of testnet-one