NET-953-tatum-miner-framework #2448
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added maintainTopology service, helper and tests to operatorplugin
Added MaintainOperatorValueService, helper and tests --------- Co-authored-by: Christoph-Samuel Pitter <christoph-samuel.pitter@streamr.network> Co-authored-by: Eric Andrews <eric.andrews@streamr.com>
## Summary Do some refactoring of code. Changes include: - Adjust log levels and messages - Remove unneeded eslint exceptions - Use `EthereumAddress` type to avoid having to lowercase in many places - Use `StreamID` type more - Remove unused code - Adjust field access modifiers - Add some missing error handling
This reverts commit 89b21da.
github-actions
bot
added
ci
|
|
|
Closing, not sure what this PR was about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 89b21da.
Summary
Please provide a summary of the changes and a motivation if applicable.
Changes
Provide a bullet list of individual changes. Leave this section out if change
set is small and obvious from summary.
Limitations and future improvements
Provide a bullet list or description of known omissions or limitations of the
solution and/or any ideas for future improvement. Leave section ouf if
not applicable.
Checklist before requesting a review
TODOcomments left behind are meant to be left in.