Skip to content
This repository has been archived by the owner on Dec 21, 2021. It is now read-only.

Add sendToMainnet option to DU API. #220

Merged
merged 14 commits into from
Mar 13, 2021
Merged

Conversation

timoxley
Copy link
Contributor

Begin adding sendToMainnet option to DU api. WIP.

@linear
Copy link

linear bot commented Mar 12, 2021

NET-228 Withdraw to sidechain with JS client

It should be possible to withdraw to the sidechain using the JS client. Currently the boolean flag controlling this is hard-coded, for example here. The user should be able to specify this parameter.

@timoxley timoxley requested a review from jtakalai March 12, 2021 20:19
@teogeb teogeb marked this pull request as ready for review March 13, 2021 09:08
Copy link
Contributor

@jtakalai jtakalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote most of that so I won't be able to really review it :D if tests pass and it's good for you, it's good for me.

@timoxley timoxley merged commit f4b0637 into master Mar 13, 2021
@timoxley timoxley deleted the NET-228-withdraw-to-sidechain branch March 13, 2021 14:10
@timoxley
Copy link
Contributor Author

Thanks for getting this across the line @teogeb @jtakalai 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants