This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
README rewrite for DU functions #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtakalai
force-pushed
the
du-readme-rewrite
branch
from
1604c24
to
411b348
Compare
fonty1
reviewed
Mar 15, 2021
fonty1
reviewed
Mar 15, 2021
teogeb
reviewed
Mar 15, 2021
README.md
Outdated
| const client = new StreamrClient({ | ||
| auth: { privateKey }, | ||
| }) | ||
|
|
||
| const dataUnion = await client.deployDataUnion() | ||
| await client.setAdminFee(0.3, { dataUnion }) | ||
| const receipt = await dataUnion.setAdminFee(0.3, { dataUnion }) |
There was a problem hiding this comment.
The second parameter (({ dataUnion }) has been removed
There was a problem hiding this comment.
it has in fact been removed ;) #224
There was a problem hiding this comment.
In #224 you remove option for another method (addMembers, removeMembers), I removed setAdminFee parameter earlier (but forgot to update this README).
Co-authored-by: Matthew <fonty1@users.noreply.github.com>
fonty1
reviewed
Mar 15, 2021
fonty1
reviewed
Mar 15, 2021
fonty1
reviewed
Mar 15, 2021
fonty1
reviewed
Mar 15, 2021
fonty1
reviewed
Mar 15, 2021
fonty1
approved these changes
Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the DU function docs to reflect the fact that we now have the DataUnion object (examples rewritten)
Also general cleanup. Please add freely to it where you see shortcomings.