This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
NET-229: Fix Memleak(s) #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests. Assert memory usage. Run in CI.
NET-229 Address Memleak
Memleak reported here: #233 Confirmed memleak when running large resends against tramdata stream. Fixed here: #236 |
… reduce flakiness on slow traffic days.
Weird error in logs, seems to be exiting with SIGTERM, but well under timeout. Not sure why.
teogeb
reviewed
Mar 29, 2021
teogeb
reviewed
Mar 29, 2021
teogeb
approved these changes
Mar 29, 2021
|
CI failure seems unrelated, merging so we can put out a new, fixed 5.x release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #233.
Found two definite leaks, and a few minor potential leaks.
Resend's
lastoption limits to 10,000 messages, but no such limit for resendfrom/to.Resend limits for
from/towith some kind of pagination like this stale PR would probably help a lot: streamr-dev/broker#190CI failure due to production resends being broken.
Might have to figure out a good way to replay large datasets in test environment, it's quite possible my testing of this yesterday caused production resends to fall over. Of course this shouldn't happen at all, and we probably should do something to break up resends into smaller chunks, for the benefit of both producer and consumer.