Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maxspeed quest : Ensure contributors choose between implicit and explicit maxspeeds before submitting #1085

Closed
gileri opened this issue May 28, 2018 · 9 comments
Assignees
Milestone

Comments

@gileri
Copy link
Contributor

gileri commented May 28, 2018

With the current wording/UI many quest answers are incorrect in France, as often maxspeed is implicit and do not require maxspeed signs. However, as the UI is biased towards sign-based speed limits, both new and seasoned users are using the default choice without checking the "other options".

At least half of those ways shouldn't have maxspeed_type=sign, as 50 kph/kmh is the default speed limit in urban areas, so those ways don't have a sign.

I believe displaying both implicit and explicit maxspeeds choices equally would reduce errors, while not impeding input. Here is an UI mockup:
fk00tf5
qwie9ae
n2crgip
k5ypvop

@gileri gileri changed the title Maxspeed quest : Make implicit and explicit maxspeed Maxspeed quest : Make user choose between implicit and explicit maxspeeds May 28, 2018
@gileri gileri changed the title Maxspeed quest : Make user choose between implicit and explicit maxspeeds Maxspeed quest : Ensure contributors choose between implicit and explicit maxspeeds before submitting May 28, 2018
@westnordost
Copy link
Member

I took the liberty of adding them here on github.

The mockup as such looks good, only for implicit speed limits it is not that easy and IMO needs more explanation - in other words, in the "worst" case, the UI flow after having selected "implicit speed limit" would stay the same.

What are the opinions of the other regulars here?

@matkoniecz
Copy link
Member

Looks OK, though normal person may be surprised by "implicit speed limit" term (and maybe also by "living street"), but I see no way to avoid it.

@gileri
Copy link
Contributor Author

gileri commented Jun 1, 2018

I agree that "implicit" could be more explicit :) When showing the urban/extra-urban choice the user should understand, but as @matkoniecz there could be better way to express that.

Living street (translated) + the sign sound easy enough to understand imo.

@westnordost
Copy link
Member

(If someone else wouldn't do this, this will probably not find its way into v6)

@westnordost
Copy link
Member

westnordost commented Jun 22, 2018

Put some more thought into this (and started it on a private branch). A few comments:

  • To not litter the main view with uncommon answers, the other items in the "Other answers..." menu should not be added. Specifically, not "living street" and not "advisory speed limit". Also because it is not a direct answer to the question "what defines this speed limit?"
  • The dialog flow of when selecting "no sign, defaults apply" should stay the same and not be simplified to as it can be seen in the illustration as long as we do not have the big picture of what maxspeed:types there are in total for each country (see default speed limits). When the linked list is ~complete, one can think about redesigning/simplifying this flow to something similar than proposed, offering different options for each different country. Because I find it necessary to see the big picture for a comprehensive tagging scheme here, I am putting this on blocked and on help wanted.

@westnordost westnordost added help wanted help by contributors is appreciated; might be a good first contribution for first-timers blocked blocked by another issue labels Jun 22, 2018
@gileri
Copy link
Contributor Author

gileri commented Jun 30, 2018

What got us here is that if users are given a default, easy answer they will most likely ignore other answers (and they do). Making the user choose between 4 options slows down maybe the first one or two contributions, but will make sure that they makes a conscious decision between them, and not just doing as little as possible to validate the quest with incorrect data. Another example

I've also started a private branch but I'm not used to Android development, so I didn't want to give any false hope by annoucing it. But since the issue is blocked on an external and open-ended task that will likely never be considered as complete, I will stop devoting time for it, except if we find another solution that is implementable in the near future.

Should the quest be disabled for the time being ?

As an aside : a road being designed as a "living street" does define a legal speed limit in a lot of coutries.

@rugk
Copy link
Contributor

rugk commented Jul 1, 2018

As an aside : a road being designed as a "living street" does define a legal speed limit in a lot of coutries.

That's why we have an option to select that.

So what is actually blocking this issue?

@westnordost westnordost added this to the v7 milestone Jul 11, 2018
@StanislavTichy
Copy link

StanislavTichy commented Jul 15, 2018

I second to the fact that while using streetcomplete for first time I have automatically filled 50kmh speed limit onto every urban road i came across. Only after some time i noticed there are other options to choose from. As a result of my experience As a translator I have rephrased the string in poeditor to be more precise about sign. In my czech language I have currently worded main quest question appearing after clicking on icon as something like that:
"Is there a speed limit sign at this street? If yes, what is the speed written?"

This sounds very clearly i think.

@gileri
Copy link
Contributor Author

gileri commented Jul 16, 2018

@StanislavTichy Sadly, even with this wording and the speed sign graphic, senior contributors make the mistake. That's why I opened this issue and pushed towards making the user choose between speed limit types and not assuming that they understood what type the default type is.

@westnordost westnordost self-assigned this Aug 4, 2018
@westnordost westnordost removed blocked blocked by another issue help wanted help by contributors is appreciated; might be a good first contribution for first-timers labels Aug 4, 2018
westnordost added a commit that referenced this issue Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants