Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu button not working any more #1806

Closed
Helium314 opened this issue May 1, 2020 · 8 comments
Closed

Menu button not working any more #1806

Helium314 opened this issue May 1, 2020 · 8 comments
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@Helium314
Copy link
Collaborator

When I tap the menu button (capacitive hardware button on the phone), the menu does not open in StreetComplete 19. The button just does nothing.
Up to StreetComplete 18.3, the menu button had the same effect as tapping the 3 dots on top right (now 3 lines).

I am not sure whether this is a bug, but it feels like an annoying change in my usual flow. Plus, I don't see any possible benefit if the change was intentional.

SteetComplete 19 (fdroid)
AOKP Pie (Lineage 16.0 based)
S4 Mini

@Helium314 Helium314 added the bug label May 1, 2020
@westnordost
Copy link
Member

What capacitive hardware menu button?

Looking at https://www.gsmarena.com/samsung_i9190_galaxy_s4_mini-pictures-5375.php ..., isn't the button to the left the 🔲 (black square) on modern devices which opens the list of recent activities (like Alt+Tab on a PC), and the big one in the middle the home button that brings you back to the launcher (=desktop on a PC)?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label May 1, 2020
@Helium314
Copy link
Collaborator Author

This (bottom left) button opened the menu by default in the earlier versions of android I used, but was switched to open recent activities later. I still use it to open the menu.
There is some setting to change behaviour of that button in my rom, and it works in almost all apps I use.

@westnordost
Copy link
Member

I see, I found that it is possible to respond to hardware buttons and implemented it.

I can't test it though, so feel free to reopen it if it does still not work for the next version.

@Helium314
Copy link
Collaborator Author

Will do, thanks!

@Helium314
Copy link
Collaborator Author

It sort of works now (19.1 fdroid), but there seem to be 2 menus on top of each other.
By this I mean I have to close the menu twice (e.g. by pressing back twice) to get back to the map.
When using the 3 line button on screen the menu opens normal.

@Helium314 Helium314 reopened this May 11, 2020
@westnordost
Copy link
Member

westnordost commented May 11, 2020 via email

@Helium314
Copy link
Collaborator Author

As long as I hold the button nothing happens.
Once I release it the menu opens twice.

@westnordost
Copy link
Member

Should be solved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

2 participants