Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handrail wird doppelt eingetragen #2162

Closed
OSMmapper opened this issue Oct 13, 2020 · 4 comments
Closed

Handrail wird doppelt eingetragen #2162

OSMmapper opened this issue Oct 13, 2020 · 4 comments
Assignees

Comments

@OSMmapper
Copy link

Mir ist aufgefallen das bei Treppen welche bereits "handrail:right=yes" und/oder "handrail:left=yes" beinhalten,
zusätzlich jetzt noch der Tag "handrail=yes" eingefügt wird.

Denke dies ist ein Doppeleintrag ohne Mehrwert.

How to Reproduce
Suche eine Treppe, welche bereits "handrail:right=yes" und/oder "handrail:left=yes" beinhaltet.

Versions affected
StreetComplete 24.1

@OSMmapper OSMmapper added the bug label Oct 13, 2020
@westnordost westnordost removed the bug label Oct 13, 2020
@westnordost
Copy link
Member

I am going to answer in English because this is nothing specific to German or Germany.

Without additional value - maybe. But this is how the tag is defined in the wiki. handrail should always be set, handrail:*=* is described only to further define the value. We have that kind of namespaced tagging in many places in OSM. I'd additionally argue that data consumers build on, to a certain degree, that the data follows the documentation, so if data consumers check for handrails, they do not necessarily check also the handrail:left/right keys if handrail is not defined.

So, unlike cycleway, where the wiki recommends to only tag cycleway:left/right instead because it is more precise, for handrail it states that handrail:left/right defines the value more precisely.

@westnordost westnordost added feedback required more info is needed, issue will be likely closed if it is not provided bug labels Oct 13, 2020
@westnordost
Copy link
Member

But in any case, one thing that I reckon now is that if someone resurveying the steps and not finding any handrail, the app should also delete the handrail:* tags, so this is the minimum that I should do about this.

Also, in regards to the argument I brought forth 2 hours ago, it would be a good idea to bring up some numbers: How much % of steps with handrail are tagged only with handrail:* and not with handrail=yes? How about the other way round?
After all what is written in the wiki is not everything and sometimes the wiki is wrong.

@westnordost
Copy link
Member

About 9% of all ways tagged with handrail are also tagged with handrail:left/right.

About 29% of all ways tagged with handrail:left/right are also tagged with handrail.

@westnordost westnordost removed the bug label Oct 13, 2020
@westnordost
Copy link
Member

Ok since this is a not negligible amount of taggings that do not conform to the current wiki documentation, I changed it so that it doesn't ask for places with handrail:* anymore except in a resurvey (every 8 years)

@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants