New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerb height node/way #2348
Comments
Is it likely that |
The adjacent kerbs: Are just tagged as Lowered should possibly be tagged as flush, I'd need to check onsite, but certainly it doesn't get any further down that that. What's the difference between |
OK to summarize, there is a way tagged with Do you have a link to documentation for this tagging (that |
Correct.
No, but after #2347 I went to look on OSM and was surprised to see it already tagged with a value, yet still being asked in SC.
The wiki says it can be used on nodes and ways: |
As I understand it, and it seems to match wiki:
There may be physical demarcation in form of a tactile paving or some extremely subtle like tiny gap between different layers of asphalt.
Not only for living streets, "no kerb" image is from |
Well I'm reading this in the wiki |
Thanks for clarifying, the "no" photo is great!
I was going off the infobox. It's also mentioned as an open issue: I don't know which wins? 😕 Given the It would be most accurate to tag that as one lowered way than three lowered nodes. From a technical perspective, presumably its possible to find the tags associated with a way that intersects, not just a node? Also if this is the detailed scheme, surely it should be detailed, otherwise wouldn't it be more simple to just tag left and right kerb on the crossing node or something. |
Yes, disabling this quest on crossing of footways with Inheriting tags from way to node on it is doable while processing OSM data (though it may be impossible or tricky in some tools or workflows) But I am unsure whatever it is preferable to do this change or not. |
Isn't it basically the same issue as whether the |
Yes, with the same issue that in typically it is repeating info from parent but in some rare cases it is useful. And sooner or later someone will map it anyway. |
I'll close this then. Such duplication has its merits for data consumers as they then don't need to puzzle together tags inherited from containing areas etc. There could be Osmose-QA/JOSM validator checks that check if information that is duplicated differs. |
I don't want to open a new issue for this small thing, but when I solve a kerb quest, they show in iD as having "incomplete tags". This is because SC only adds kerb=value to the node; selecting "Upgrade the tags" in iD adds barrier=kerb. It would save some work if SC would add barrier=kerb as well as kerb=value |
@matkoniecz what do you think? |
Although presumably realising something is an area and working out if a way is contained by it is far more complicated than just finding out if two ways intersect each other?
Surely SC should only be finding ways/nodes with barrier=kerb to be asking the question? Otherwise how did it know it should pose the question. Or is it a literal continuation of my query where it's found a way tagged with barrier=kerb intersecting with a crossing but then it's added the kerb=value to the node not the way? If we're saying duplication has benefits, then shouldn't it tag the equivalent bits that it found (i.e. the way if it found the kerb tag on a way), even if it tags the node as well. |
If you mean by intersection that two ways share a node, then yes.
See #1305 (comment) By the way, it is preferrable that if you have something more to add, to add another comment rather than modify what you've written. I oftentimes only read the email and not actually go to github to read the (maybe edited) message. |
Yeah IMHO if SC is adding the kerb=value tag on a node when it found barrier=kerb on a way it should add barrier=kerb too (although personally I think it should still mirror the existing tags, i.e. if it was found on a way it should add it to the way).
Apologies, I think we all fall into that trap occasionally 😉 |
A OSM router will probably only look an the tags of the route and not connected ways. So +1 for adding the barrier tag. |
Okay, makes sense, @HolgerJeromin @matkoniecz this is your quest, what do you say? |
Well, I added it now. If you have objections, put them here. |
From what I remember it may lead to some duplication, but in case of crossings everything is duplicated already so... |
Personally I'd have thought that means the routers should be fixed, but maybe that's more complicated than it seems.
Given we're already potentially duplicating a way tag onto a node already... |
I think I'm being asked unnecessarily about kerb height on a node when it's present on the way. Similar to #2347 for tactile paving on the node/way.
How to Reproduce
This way (the kerb):
https://www.openstreetmap.org/way/427341975
Has kerb=lowered, but I'm still being asked at that point, is that because it's not on the node itself ( https://www.openstreetmap.org/node/5125180422 ) I think?
Versions affected
v27.1
The text was updated successfully, but these errors were encountered: