Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skybridges/skyways as an option to the building quest #2630

Closed
Identitaet opened this issue Mar 3, 2021 · 8 comments · Fixed by #3320
Closed

Add skybridges/skyways as an option to the building quest #2630

Identitaet opened this issue Mar 3, 2021 · 8 comments · Fixed by #3320
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits

Comments

@Identitaet
Copy link

Use case

Enable mapping of such structures
(I mean those enclosed skyways which have a roof and walls like
http://correctionalnews.com/wp-content/uploads/2018/09/SonomaCounty-800x445.jpg
Or
https://placesjournal.org/wp-content/uploads/2016/05/yoos-james-multilevel-metropolis-15.jpg
Proposed Solution

Ideally add a tag for those kinds of structures

Sadly it's a bit unclear how to tag them but I found this
https://wiki.openstreetmap.org/wiki/Item:Q16636

@matkoniecz
Copy link
Member

https://wiki.openstreetmap.org/wiki/Item:Q16636

Note that it is contentless bot-generated data item page. If there is no entry on OSM Wiki then taginfo entry is far more useful (in this case: https://taginfo.openstreetmap.org/tags/?key=building&value=skyway )

@westnordost
Copy link
Member

I'd say that this building type (if you can say that it is a building) is far too rare to be in that list. Better leave a note in that case.

@westnordost westnordost added the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Mar 3, 2021
@Identitaet
Copy link
Author

Okay so I didn't find the right tag at first

But I checked again and it seems that instead of skyway building=bridge is used
https://taginfo.openstreetmap.org/tags/building=bridge

This one got 1.5k uses
Don't know if you'd consider that relevant enough

@Discostu36
Copy link
Contributor

I also think building=bridge should be added. These structures are very common in urban areas, and it should be possible to tag them correctly with SC.

@kmpoppe
Copy link
Contributor

kmpoppe commented Sep 25, 2021

Given we have "Pagoda" in the "Religious Buildings" area, which has less than 150 uses in the map, I'd also say, that adding building=bridge with 1.7k uses wouldn't be totally out of touch. Additionally, @Discostu36 has cleaned up the Wiki to make it clear, what that tag means.

Again, in my urban area there are plentyful where that'll apply:
grafik

That would be my solution that I can PR any time, given @westnordost would accept it.
grafik
grafik

@westnordost
Copy link
Member

Oh, that's the meaning of building=bridge?

@westnordost
Copy link
Member

Anyway, the icon looks good. Since you seem to already have implemented it, care to create a PR to include it?

@kmpoppe
Copy link
Contributor

kmpoppe commented Sep 25, 2021

Done. Included a German translation (as per my testing), if you want this to be done with POEdit, you can remove the file from the branch as I allowed edits from maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix idea rejected because it is out of scope or because required work is not matching expected benefits
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants