Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add building type bridge (skyway) #3320

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

kmpoppe
Copy link
Contributor

@kmpoppe kmpoppe commented Sep 25, 2021

Adds new building type bridge to the building quest, solves the already closed #2630

Adds new building type `bridge` to the building quest.
@matkoniecz
Copy link
Member

Note

I'd say that this building type (if you can say that it is a building) is far too rare to be in that list. Better leave a note in that case.

#2630 (comment)

@kmpoppe
Copy link
Contributor Author

kmpoppe commented Sep 25, 2021

I have noted that comment. I just don't concurr that it's too rare to be part of StreetComplete, especially in urban areas. Additionally, taginfo shows a constant growth in use, so it's not an abandoned way to tag skyways as of right now.

Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add "bridge" to commercial category too?

@westnordost
Copy link
Member

Hmm, thinking about this ... does a skyway actually count as an own building? I'd think that it is just a building part and the whole building would be the part on one side of the street and the part on the other side of the street?

@westnordost
Copy link
Member

NEvermind, it is documented that way in the wiki.

@westnordost westnordost merged commit a5dbdf0 into streetcomplete:master Oct 1, 2021
@kmpoppe kmpoppe deleted the building-bridge branch October 5, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add skybridges/skyways as an option to the building quest
3 participants