Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't check opening hours of disused shops or amenities #2712

Closed
kjonosm opened this issue Apr 1, 2021 · 2 comments · Fixed by #3719
Closed

Don't check opening hours of disused shops or amenities #2712

kjonosm opened this issue Apr 1, 2021 · 2 comments · Fixed by #3719

Comments

@kjonosm
Copy link

kjonosm commented Apr 1, 2021

see here
@Helium314
Copy link
Collaborator

Is it actually correct for a disused amenity to have opening hours?

@westnordost
Copy link
Member

No, it isn't. This is an error in the data

@Helium314 Helium314 mentioned this issue Feb 4, 2022
Closed
matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Feb 4, 2022
@matkoniecz
better deal with bad OSM data for OH
eae0c48 
fixes streetcomplete#3718 and fixes streetcomplete#2712

now old opening hours will be asked only when on objects eligible for new opening hours
and for some additional limited cases when opening hours are tagged already and become old
such as parks, barriers, toilets
@matkoniecz matkoniecz mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better deal with bad OSM data for OH matkoniecz/Zazolc
3 participants
@westnordost @Helium314 @kjonosm