Asking for addr:street if addr:housenumber has just been added

[kmpoppe]

Hello everyone,

Ludwig Anten reports in https://t.me/OSM_de/53072, that he was asked for a addr:housenumber and for building:levels directly afterwards, even though he was expecting to be able to add addr:street.

While

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/QuestModule.kt

Lines 137 to 138 in 9d8b615

	AddHousenumber(),
	AddAddressStreet(roadNameSuggestionsDao),

lists both quests directly after one another in the "Important data"-category, that didn't seem to happen.

The reason is simple:

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/quests/address/AddAddressStreet.kt

Lines 24 to 25 in 9d8b615

	nodes, ways, relations with
	addr:housenumber and !addr:street and !addr:place and !addr:block_number

only applies, when addr:housenumber exists.

So obviously the AddAddressStreet Quest will not be included in the "first" filter - i.e. would only apply if you had answered the housenumber and then searched for new quests in the same place again.

If we want to keep the filter the same (which is okay-ish in my view), would there be a way to mark Quests (AddHousenumber) that will ask the app to re-evaluate the quests at the given position because a Quest was answered that is important to a filter of another quest (AddAddressStreet) ?

^Kai

[TurnrDev]

I think quests for any given object should be re-evaluated as soon as a question is answered

Related, I hate waiting for new quests to load when marking a shop as a new type of shop.

[westnordost]

Ok, I could go into detail into why, but I will skip to the point:

1. The address street quest does currently not pop up when you answer the house number quest, not even if you uploaded it
2. For the next major version, the address street quest will pop up immediately after answering the house number quest, even if you are offline

[kmpoppe]

@westnordost 🤷‍♂️ I always love details, but anyhousel. Thanks, will pass the information on!

[westnordost]

Details about the big-ass refactor are here, #2506 with pictures