Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[already in v31] at least some flags are overly stretched horizontally #2819

Closed
matkoniecz opened this issue Apr 28, 2021 · 3 comments · Fixed by #2831
Closed

[already in v31] at least some flags are overly stretched horizontally #2819

matkoniecz opened this issue Apr 28, 2021 · 3 comments · Fixed by #2831
Labels

Comments

@matkoniecz
Copy link
Member

screen

How to Reproduce
Edit in Israel/Cyprus, login, view flag screen
Versions affected
v31, v32

@matkoniecz matkoniecz added the bug label Apr 28, 2021
@matkoniecz matkoniecz changed the title [already in v31] flags are overly stretched horizontally [already in v31] at least some flags are overly stretched horizontally Apr 28, 2021
@peternewman
Copy link
Collaborator

Does it render correctly when you tap on it?

It's centre:

i.e.

val w = d.intrinsicWidth
val h = d.intrinsicHeight
val scale = width.toFloat() / min(w,h)
val hOffset = -w * scale + width

FlagAlignment.CENTER -> Rect((hOffset / 2f).toInt(), 0, (hOffset / 2f).toInt(), 0)

The numbers all look plausible to me from a quick play.

@westnordost
Copy link
Member

When you tap on it, it's not the CircularFlagView anymore

@westnordost
Copy link
Member

But anyway, Peter is on the right track here. The configuration seems correct, there must be some bug in CircularFlagView. To try to reproduce, I'd probably create a simple test fragment that I can open from the settings or so in which only one CircularFlagView of my choosing is displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants