Fix keyboard not appearing in TimeRangePickerDialog (fixes #2799) #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have never noticed that part of the interface :) Tested, confirmed to be fixed, thanks for finding workaround! I would need like a month of work to discover that. |
|
Wow, really cool that you found that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in the
AlertDialog's Javadoc, the class normally automatically takes care of setting theWindowManager.LayoutParams.FLAG_ALT_FOCUSABLE_IMwindow flag by checking if the dialog's view contains anEditText. However, this does not seem to work with theTimePicker, which displays a clock dial by default. This PR fixes this problem by setting the correct window flags by hand. On my device, the keyboard can now be opened by clicking in the text fields.