Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in notes should be clickable #2905

Closed
arrival-spring opened this issue May 25, 2021 · 1 comment · Fixed by #2918
Closed

Links in notes should be clickable #2905

arrival-spring opened this issue May 25, 2021 · 1 comment · Fixed by #2918

Comments

@arrival-spring
Copy link
Contributor

It would be nice if links in notes were clickable.

I noticed this as I have it set to show all notes and when I added a new note with a photo the link was not clickable.
On that note, it does seem a bit odd to add a note through the app and have it appear as a quest to be solved, but having read the comments where this change was discussed, that does seem to be the desired behaviour when the "show all notes" option is on.

The text in the note popup is selectable and then Android seems to recognise that it's a url and auto selects the whole thing on a long press and adds a tooltip option to open the link, but this isn't very intuitive.

@peternewman
Copy link
Collaborator

On that note, it does seem a bit odd to add a note through the app and have it appear as a quest to be solved, but having read the comments where this change was discussed, that does seem to be the desired behaviour when the "show all notes" option is on.

OT, but that's been raised with comments from #2692 (comment) onwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants