Allow user to see/comment on ALL open Notes (even their own) #2692
Comments
|
So if note would be present it would never disappear, even once answered? Or would it reappear on rescan? Also, see #569 |
westnordost
added
the
feedback required
|
Maybe notes could show again if there is a new comment since it was hidden in SC. Something like that would be very useful for me too. |
|
@matkoniecz I don't understand what you mean by "even once answered"? Can notes be "answered" in SC? I've only been able to add additional comments to them (when clicking on Note and being presented with So yes, if Edit However if some people think it might be useful for them, I have nothing against that preference being radio button choice (instead of boolean toggle as it currently is) - something like: |
Given SC presumably tracks something about notes to hide some when you choose, if it also tracked the IDs of notes created by you in SC some further granularity could be added (which would cover everyone apart from people using SC on two separate devices, or perhaps that could be covered by note metadata?):
Working on the principal that you could add a note in iD or whatever and then see it as if another user had created it in SC, which would cover the majority of most people's use cases (aside from @mnalis stream and railway examples). |
I meant "comment added with SC or user user selected 'no, hide' in 'Can you contribute anything to this note'" by "answered". |
|
That's too many options!
…On April 1, 2021 4:24:07 AM GMT+02:00, Peter Newman ***@***.***> wrote:
> ```
> Show all notes:
> - [ ] only open foreign notes phrased like a question (recommended)
> - [ ] all open foreign notes
> - [ ] all open notes (even your own)
> ```
Given SC presumably tracks something about notes to hide some when you
choose, if it also tracked the IDs of notes created by you in SC some
further granularity could be added (which would cover everyone apart
from people using SC on two separate devices, or perhaps that could be
covered by note metadata?):
> ```
> Show all notes:
> - [ ] only open foreign notes phrased like a question (recommended)
> - [ ] all open notes phrased like a question (including yours)
> - [ ] all open foreign notes
> - [ ] all open notes (even your own, except ones you've commented on)
> - [ ] all open notes (even your own, including ones you've commented
on)
> ```
Working on the principal that you could add a note in iD or whatever
and then see it as if another user had created it in SC, which would
cover the majority of most people's use cases (aside from @mnalis
stream and railway examples).
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#2692 (comment)
--
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.
|
|
@westnordost I do agree that is too many options which would confuse users (and yet does not cover all possibilities that user might want - I myself can think of few more!) So, I'd go with at most 3 options as I suggested previously, and that only if people who are currently using @matkonicz ah, I see now. I never used that option on Notes it seems. I guess SC tracks it internally somehow (as I don't see Notes change on server when I select it for test). I guess If so, it could either continue to behave as it was previously (as user is explicitly requesting to hide it). Alternatively, |
|
There is another middle ground:
Part of the reason I like this is that the current implementation of restoring hidden quests isn't 100% ideal. Usually when I tap that button I only want to restore one quest; it would be better if there were a UI for viewing hidden quests (on the map) and restoring them individually. If something like this were added in the future, it would also work well as a place where you can view your own notes. |
I'm guessing you don't want to add (and have to code and test) multiple drop downs which that is effectively trying to hide:
But from a workflow perspective, it's likely that if a note has been opened outside of SC (regardless of whether you or someone else opened it), it probably needs someone on-site to answer it (using SC), and if someone (or you) has responded to it (on SC) it's likely the on-site answer has been provided. i.e. the foreign should be the app, not the creating user. I'd probably go as far as to say that if someone has opened a note "well" (good notes/photo) on-site using SC, it's unlikely another on-site user can do anything useful, it needs some tagging checked etc.
But then there is no way to hide a note apart from by commenting on it @mnalis ! |
I assume you just mean when specifically leaving a note (unless it's a line in the existing dialogue it's going to really drag if you have to tap through that whenever you "Can't say".
But that leaves things stuck (or arguably worse) until that's implemented. As most notes which I've hidden are generally stuff I can't help with on-site. |
I see #748 lets you undo hiding stuff, presumably also including notes, so this point may be moot, as long as it's a recent quest at least. |
|
On the other hand, the (awesome!) UI in #748 (comment) is very close to what I was imagining in #2692 (comment). I want to play around with it before offering any concrete suggestion, though (especially to see if I even care at all, being able to undo notes now). |
|
Hi @westnordost , The commit comment in 98cc1bc is "showing all notes now shows all notes except where the user is the last one to comment to" but from my experience there is an unexpected side effect. I think there are a few different types of notes:
If I'm not the last person to comment (as per the commit comment) then I might be able to add something, so I want to see the notes. i.e.:
If I've already replied, I'm unlikely to have much to add (in most circumstances):
Potentially unless it's particularly old, but hopefully I answered accurately at the time. I guess if it was say 3/6 months old I could confirm what I said was still true. Finally there is:
This is a bit of a grey area, depending on your interpretation of "except where the user is the last one to comment". I think there are two scenarios though. Firstly the user just created the note in SC, which is what I keep seeing, you can't say and add a note and obviously it pops up immediately. This also means you can't answer any quests "under" it unless I hide it. Would it re-appear if someone needed more info from me though and they replied? Secondly if I leave a note (most likely not in SC), but more generally some time earlier when not on-site, then anyone on-site (including myself) could likely answer it. Suggested solution, hide notes with no comments just the opening message created by myself in SC, either indefinitely or for say 24 hours after creation (or some shorter time; obviously tuning that is a balance between how much waiting I need to give after adding a note in iD say, and not seeing a note on the walk back on a wander). |
|
Sorry, I missed your point. Can you write in short what is the behavior that currently occurs but you don't want to see? |
|
Answer a quest with can't say and add a note, or probably add a note directly too, and it immediately appears back in SC! |
|
I frequently leave comments (and/or notes) for myself in other apps to answer when I'm out and about in SC. For me, the right behaviour should be that if the last comment (or the note itself if no comments) was created by me in StreetComplete then don't show it, otherwise do. |
Agreed. I've even created a note in SC, then replied to my own comment on OSM.org asking myself to re-check again during survey, for me to answer again in SC.
last comment, unless no comments, then the note itself |
That's deliberate. Someone in this thread mentioned that he wrote a note in SC (to himself) but later wanted to comment on it. Would you rather have the behavior as @dbdean described? Give me your thumbs. |
On which comments? |
|
On mine |
I think my time based solution would keep everyone happy (potentially combined with @dbdean 's so the time only applies to SC originated notes where you are last):
The only possible reason I could see for wanting to see a note I'd just created in SC within SC would be if I say walked round the corner and found something else and realised I should comment on it, but for those rare events, I'd imagine a second note would be the easiest solution. |
This comment has been minimized.
This comment has been minimized.
For start, are you running v32 ( https://github.com/streetcomplete/StreetComplete/releases/tag/v32.0 ) or some older version? Have you enabled setting to show all notes? |
|
@matkoniecz oops, you are right, it seems I've reset it to off while testing on that phone (and main phone with correct setting is still on @dbdean if you want to have your own notes hidden, then you should simple keep @westnordost I'm somewhat confused by voting, are thumbs up for support of the "That's deliberate" current behavior (which you implemented in 98cc1bc), or in support for changing it to dbdean's idea? Anyway I'm in support of showing all notes if |
|
Thumbs up: changee to what dbdean proposed, thumbs down: keep as it is in v32.0 |
|
Perhaps different people really have different preferences, so best way might be 3 choice question instead of yes/no question? Of if not, and there would be no possibility in SC to show all notes (which would work best for me, but I seem to be somewhat outspoken), perhaps at least translation of that preference should be changed from |
|
I made this table as part of a longer comment that I decided wasn't worth posting. But maybe this is still useful.
|
| Author of latest reply | Note was opened by self, in SC | Note was opened by self, in other editor | Note was opened by someone else |
|---|---|---|---|
| Self | ❌ | ❌ | ❌ |
| Someone else | ➖ | ➖ | ➖ |
| Someone else, and the reply is a question | ✔️ | ✔️ | ✔️ |
| No replies yet | ❌ (changed from ➖) | ➖ | ➖ |
| No replies yet, and the original note is a question | ➖ | ➖ | ✔️ |
✔️ = Always shown
➖ = Only shown if "Show all notes" setting is enabled
❌ = Never shown
|
I find this table confusing. |
|
The table is intended like #2692 (comment), but in 2d. I guess I'm also missing an "…and is a question" column for "No comments". |
|
I made it because I was having a hard time following all the different variations on behavior. So the table may be wrong. I updated it (including inverting the rows and columns) so hopefully now it is easier to follow. I'm not going to spend any more time on it, so if it's not useful and you all are clear on what you're talking about, ignore & move on. |
I do want to see all notes, but I don't see a lot of value in SC-created notes appearing immediately in SC, especially when done in response to quests.
No worries, my solution (only show user notes when the last comment, or note if no comments was not created by the user in SC) would be ok for this.
Is this in response to a quest, or are you adding a custom note? If it is response to a quest, can't you just leave the quest unanswered?
So just leave the quest unanswered? |
|
I could see some value in custom notes always showing, regardless of the creator. Answers to custom notes in SC should still hide the note though, at least until another comment happens. Maybe an checkbox option on the form to hide notes when you create them? |
|
@dbdean yes, I'm mostly interested in custom notes. Although some minority are quest notes too (esp. when it probably needs a split but unknown where, or when I definitely want to visit that location on way back as I find it more important than 99% of the quests, eg. "is that water on that hill over there drinkable"). As for differentiating between custom notes and quest notes in the map display logic, I'm not sure how easy it would be to implement (I'm afraid not too easy). However if it was easy, it would work good enough for me if all custom notes (no matter who or when created or commented on them) were always shown when BTW leaving quest unanswered only works if you've cleared pretty much everything else. If your even a smallish area has hundreds or even thousands of unanswered quests (as most of mine do), it is hopeless. As for checkbox option to hide, it probably adds unnecessary complexity (but would also work for me). You can click and hide notes even now if you want - it is just a click or two more. But you can never show hidden notes, which is much bigger problem if you want to see them. |
I'm a bit confused @mnalis . If you're answering the quest with a note, it vanishes, and you can't actually split it when you get to the split. Although with the new offline stuff you can always split it multiple times, i.e. each time you come to a change in surface or whatever.
Personally it feels more like notes for yourself (during a survey) and other notes. If there's say a "what sport is played here" and you answered it with a note "there's now a building", someone might comment back saying what is the outline of the building and you'd resurvey that etc. i.e. it's the standard note/question and then "answer", further question, answer etc. If they don't hide once you've commented, are you hiding them when you've finished your survey? What happens if someone comments on it after you're done? Or are you "hiding" any notes by doing the edits and resolving them when back at your computer? I guess the other notes are your request for private ones: #2559
Those numbers stagger me, or the fact they're related. I can go somewhere where e.g. houses have been just mapped as buildings, and have loads, but they're all standalone and don't interact. Although looking at your screenshots in #2559 perhaps you're talking about when zoomed out a lot, in which case that's true in Central London too, but surely you're not actually trying to answer quests when zoomed out that much as you aren't near them? Have you considered turning off most of the quests and going one or two types at a time to get it to a more manageable number?
Doesn't the undo thing allow you to do that now? Although not programatically hidden ones versus ones which have been chosen to be hidden. I know @westnordost doesn't want lots of settings, but personally to me this desire for SC to essentially be a notes browser is another level further from the quest type model so there should be the ability to see all notes I've not responded last to separately from every note ever. Unless they get unhidden when someone replies which would work as a compromise for me. |
|
So, this is the logic now, to show all notes except:
|
|
It is not possible to ascertain with which app a user replied to a note, so it is not possible to also show notes where the user replied last but with another app. |
|
Code should btw. be easily readable: private fun Note.shouldShowAsQuest(
userId: Long,
showOnlyNotesPhrasedAsQuestions: Boolean,
blockedNoteIds: Set<Long>
): Boolean {
if (id in blockedNoteIds) return false
if (comments.last().isReplyFromUser(userId)) return false
if (probablyCreatedByUserInThisApp(userId) && !hasReplies) return false
if (showOnlyNotesPhrasedAsQuestions &&
!probablyContainsQuestion() &&
!containsSurveyRequiredMarker()
) return false
return true
} |
Doesn't SC embed in the content "by StreetComplete", could search for that. |
|
@westnordost If I read it correctly, I see that a0fa130 changes behaviour to show even less notes when "Show all notes" is enabled. Which is fair, as majority seems to wanted it that way. This is however completely opposite of what this issues was suggesting (showing more notes when "Show all notes" is enabled). So I was wondering, would you accept PR that changed
1st option would show all notes, expect those users have manually blocked ( |
|
No, I wouldn't. |
Related to #1029, it would be nice if SC user could see all open Notes (including their own Notes).
Use case
I would prefer if
Show all notespreference would in fact be showing all notes (and not only notes that the user currently logged in via SC has never interacted with, which seems to be current behavior). Some of the reasons:litsometimes] etc.)Current workaround is using additional app on the mobile and switching between it and SC (which has it's own set of problems - not only is it quite unergonomic and delays the mapping, switching apps also causes SC to lose GPS signal and never acquire it automatically again in some annoyingly high percentage of cases, which requires closing and opening the app again, and is annoying)
Proposed Solution
Make
Show all notespreference setting to do exactly that if enabled - show all Notes (and not filtered subset of Notes).The text was updated successfully, but these errors were encountered: