Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask if something is still disused #3158

Closed
4 of 5 tasks
arrival-spring opened this issue Aug 13, 2021 · 5 comments
Closed
4 of 5 tasks

Ask if something is still disused #3158

arrival-spring opened this issue Aug 13, 2021 · 5 comments
Assignees

Comments

@arrival-spring
Copy link
Contributor

General

Affected tag(s) to be modified/added: disused: prefix or check_date:disused
Question asked: Is this still out of use? (%s)

The idea is to cover objects, mainly or exclusively nodes, which are not covered by the vacant shop quest.

Checklist

Checklist for quest suggestions (see guidelines):

  • 🚧 To be added tag is established and has a useful purpose
  • 🤔 Any answer the user can give must have an equivalent tagging (Quest should not reappear to other users when solved by one)
  • 🐿️ Easily answerable by everyone from the outside but a survey is necessary
  • 💤 Not an overwhelming percentage of quests have the same answer (No spam)
  • 🕓 Applies to a reasonable number of map data (Worth the effort)
    There aren't more than a few thousand of any of the obvious things I can think to check for

Ideas for implementation

Element selection:
disused:amenity=phone
disused:amenity=parking
disused:amenity=fuel
disused:leisure=pitch
disused:leisure=playground
disused:tourism=hotel
and older 5 years

Or maybe not all of these or maybe some others.
5 years could be about right to wait before checking, although maybe different lengths of times for different objects.

Metadata needed:
Possibly things like not including disused:ameneity=phone mapped together with emergency=defibrillator in the UK at least, where a number of old telephone boxes have had defibrillators put into them.

Proposed UI:
Is this still out of use? (%s)
This was marked as out of out of use

  • It is still out of use
  • It is in use now
  • It is no longer here

These options would:

  • Add check_date:disused
  • Remove disused: prefix
  • Remove node or remove tags as appropriate
@10992-osm
Copy link

Is there any country where disused (removed) telephones are likely to be reinstated?

@andrewharvey
Copy link
Contributor

Is there any country where disused (removed) telephones are likely to be reinstated?

Well here in Australia it wouldn't surprise me if some old broken public pay phones (disused) are reinstated since the telephone company are allowed to install them where every they like even if the local government doesn't want them, so they install a phone so they can make money with a huge advertising board on the back.

@arrival-spring
Copy link
Contributor Author

Where I am, most phones would not be likely to be reinstated, but other things like parking might be.

If things are physically removed then they should be removed from the OSM db is my main thinking behind this quest.

@matkoniecz
Copy link
Member

matkoniecz commented Aug 14, 2021

I like this idea in general but in many cases there is disused:amenity=something amenity=something_else tagging making it a minefield for processing without manual review of all tags.

Say disused:tourism=hotel building=yes shop=trade name=Foobar brand=Bazb - should name be removed or not? What about brand tag? What about every single possible tag? I have seen cases in either direction (for example name referring to new one, operator to an old one) :(

It seems unsurvivable problem to me - and as much as I would like to help in deleting historic data from OSM that have no place here, it seems not fitting into SC.

https://taginfo.openstreetmap.org/tags/disused%3Aamenity=phone - 3 uses worldwide
https://taginfo.openstreetmap.org/tags/disused%3Aamenity=parking - 1007 uses worldwide
https://taginfo.openstreetmap.org/tags/disused%3Aamenity=fuel - 1040
https://taginfo.openstreetmap.org/tags/disused%3Aleisure=pitch - 687
https://taginfo.openstreetmap.org/tags/disused%3Aleisure=playground - 121
https://taginfo.openstreetmap.org/tags/disused%3Atourism=hotel - 881

@westnordost westnordost self-assigned this Aug 16, 2021
@westnordost
Copy link
Member

Thank you for the research. I would close this on the basis of what @matkoniecz said.

However, I won't close it yet because I looked through the disused:* namespace on taginfo and found that there are lots of disused:amenity etc and that is currently not covered by the existing quest. I will implement that.

westnordost added a commit that referenced this issue Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants