geo: intent does not change map location

[mnalis]

SC implemented geo: intent back in #190 - however (as noted by @smichel17 in #426 (comment)) while it does seem to open SC when it is selected in list of supported apps, it does not seems to position SC at specified coordinates (instead SC seems to remain at last coordinates it was on). Correct behaviour should be that SC positions to specified geo: location.

How to Reproduce

• open some other mapping app like OsmAnd
• click an share geo: button in it
• select StreetComplete in the list
• StreetComplete v38.1 opens, but does not position to location that was selected in OsmAnd

Note: the bug is reproducible with vanilla 38.1, however if I try to share to @Helium314 fork v34.0-beta1 version (that I also have installed, in parallel) it seems to change position fine there. So perhaps something broke between those versions?

Versions affected
SC v38.1, Android 10

[matkoniecz]

And now for actually useful comment.

Note that in v34.0-beta1 this works only when "follow current location" is disabled, otherwise move is immediately undone. But it works in such case.

[HolgerJeromin]

This is a recurring regression:
#2227, #1426

[matkoniecz]

bisecting between v34.0-beta1 and current version found 5820b40 as point where it reappeared

[smichel17]

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/MainActivity.kt

Lines 118 to 125 in ab3b1d7

	private fun handleGeoUri() {
	if (Intent.ACTION_VIEW != intent.action) return
	val data = intent.data ?: return
	if ("geo" != data.scheme) return
	val geo = parseGeoUri(data) ?: return
	val zoom = if (geo.zoom == null || geo.zoom < 14) 18f else geo.zoom
	val pos = LatLon(geo.latitude, geo.longitude)
	mainFragment?.setCameraPosition(pos, zoom)

Perhaps the FragmentContainerView means the MainFragment is initialized late and still null at the time of this call?

This is a recurring regression: #2227, #1426

Probably a good idea to write a test or two for it

[matkoniecz]

Probably a good idea to write a test or two for it

Personally I have no good idea how to setup something automatically testing this

[westnordost]

In StreetComplete, there are not any UI tests. I think UI tests are not worth the effort. It is likely that you identified the issue correctly. Not sure how this could best be fixed though... adding a delay?