-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New quest: Detail what landuse=orchard produces #368
Comments
Forget trees, bushes or fruits. The user (and we) don't care if apples grow on trees or bushes. If he sees apples, he will want to mark "apples" and be done with it. |
Oh, this made my day. But you're right… I am currently looking for statistics. For copyright reasons I do not want/cannot to share one here, so could you drop me a mail, so I can reply? As for a worldwide overview you could take https://de.statista.com/statistik/daten/studie/28991/umfrage/erzeugung-von-obst-weltweit-nach-arten/ or https://en.wikipedia.org/wiki/Agriculture#Crop_statistics. |
Sent |
Ah, I think I finally found a good (and also reliable, for what's it worth) source. It seems you can also download the data as CSV. --> http://www.fao.org/faostat/en/#rankings/commodities_by_country One has to tweak it a bit here, it e.g. also includes other things, such as meat, but apart from that, these are some stats. |
I've finished my parser, so here it is: https://github.com/rugk/crop-parser Now I also know that in Faroe Islands mostly only potatoes 🥔 are produced… 😃 In the data, we often have many variants of the same "basic" product. E.g. beans in all colours… 😉 |
However, one can also see the amount of different fruits there is. (and these are only the top 5 per country) Getting a picture for each one could be difficult/cumbersome, so you likely need to start with a few placeholder pictures. |
Wow, cool. I anticipated you'd go through it by hand. Some notes:
|
Yeah, converting the crops to OSM tags is another thing, which should be added. However, now you at least have an overview.
Yeah, there is a blacklist.
Ups, yeah. There was a mistake in the parser (it sorted one time too much). This is fixed in rugk/crops-parser@73793ba.
Grapes are now included. Pears are only in Belgium in the top-5. Seems we overestimate the production… 😄 (at least in tonnes) Taken from the raw data in Germany only 44972 tonnes pears, 155300 pears (dry) and 28917 pears (green) were produced (Note they are not summed up in the parser currently.) . That's less than cabbage ("and other brassica") with 802888t. |
Now it is probably too late to say that, but today it came to me that it may also be a good approach to simply note down the climate zone(s) for each country in an YML and then show the different crops based on these zones. Because I have the impression that what is being planted is more dependent on the climate zone instead of the country. Could this be? Because, there are just too many crops that can be grown within a country. Even if they are not in the top X, they should still be displayed right? Mentioning all of the possible ones for each and every country is perhaps too much work (to maintain). |
Hehe, yeah, maybe. But we would need new data for it. However, island and so on (MH or the example I already mentioned above: Faroe Islands) may be special examples…
Hmm, maybe. |
So I've looked a bit for statistics and it was quite hard as mostly the natural vegetation is considered, but here at the bottom we have some data, at least for Africa, although the climate zones are of course the similar in the world. (They should be, actually…) However the data there is still quite vague and the list is often very small. So it is not the data you want to use to limit what should be shown to users. There are also so-called agro-ecological zones, but these have to be made for each region and maybe are even smaller (more detailed) than climate zones, so we won't get far here. In any case I actually like the hard facts/data we have per country, so maybe sticking to them is the best idea. We can, of course, generate another list of the top-20 crops per country, so we have really every fruit produced there in the list. In a test run I did so and here is the result. We could of course also just include all available data by not limiting the list… (For Germany there are around 70 crops listed) |
Uiuiui, so much data...
I think with more than 4 rows of icons in an image list, it really gets unübersichtlich. If there are so many different types of orchard crops, keep in mind that all of the possible ones need to be translated into every language and possibly (if it'll be a list with images) find pictures for it.
So I guess, to limit the work, the quest should only start with the most popular crops and can be extended over time to include more.
The app could ignore those crop types from the YML it does not have resources for.
…On 2 July 2017 15:34:15 CEST, rugk ***@***.***> wrote:
So I've looked a bit for statistics and it was quite hard as mostly the
natural vegetation is considered, but [here at the
bottom](http://www.fao.org/docrep/S2022E/s2022e06.htm#2.2%20major%20crop%20zones)
we have some data, at least for Africa, although the climate zones are
of course the similar in the world. (They should be, actually…)
However the data there is still quite vague and the list is often very
small. So it is not the data you want to use to limit what should be
shown to users.
Maybe we need a searchable text input here.
There are also so-called [agro-ecological
zones](http://www.fao.org/docrep/W2962E/w2962e-04.htm), but these have
to be made for each region and maybe are even smaller (more detailed)
than climate zones, so we won't get far here.
In any case I actually like the hard facts/data we have per country, so
maybe sticking to them is the best idea. We can, of course, generate
another list of the top-20 crops per country, so we have really every
fruit produced there in the list. In a test run I did so and [here is
the
result](https://gist.github.com/rugk/d43700234e6a3023c6a8384ea6644ec9).
We could of course also just include all available data by not limiting
the list… (For Germany there are around 70 crops listed)
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#368 (comment)
--
Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.
|
Okay, another idea: OSM allows "cereal" as a crop tag? Maybe we could include this? I mean the user may not be able to choose, which cereal exactly and the cereal may change, but at least "cereal" would be something, would not it?
|
Looking through OSM wiki, the tags for crop or produce are really rare. E.g: Are coconuts "crop=nut"?? I've adjusted the script to convert the output to OSM tags using a small database created out of the (englisch) OSM wiki. PS: As for the climate zone thing I noticed that at least the trees on OSM are actually categorised. (Tropical, Subtropical, Temperate) |
OSM or the OSM wiki is somehow bad. Just found some |
I dare to say that by now, you did more research than the one who made the wiki page. You can add new trees if any one tree is not mentioned or documented wrongly |
@csv database: I'd use trees wherever it makes sense. I have the impression that the trees key is more for plantations/orchards - perennial plants and that the crop key is more for farm landuse. |
Yeah, sure I could just add/invent my own tags there, but I want to stay compatible to existing mapping standards. If we assume everyone follows the wiki page I can surely do so… I'll do some work here… |
The mapping standard is trees=*. Don't expect the wiki to be complete, it is a wiki. |
In any case, this question is still open:
|
So finally here is a list of missing OSM tags (created with the data from 2013/24, using the blacklist). |
Aren't all of the crops in the list non-permanent (non-perennial) crops?
Cereals are non perennial, it doesn't make sense to capture this data in OSM when it may change several times a year. Don't suppose that it will be "some kind of cereal" all year through on the same field everywhere. Even in Germany it could be canola ("Raps"), cabbages, beet etc in between, depending on the demand. Also, only in industrial agriculture with intensive fertilization and pesticides it can be sustained to plant year after year the same crops. Non industrial agriculture will use crop rotation and that would be throughout most of the world. |
Ah, yeah, right… Seems sometimes even potatoes are used.
(Hopefully) not only there.* I just skimmed the German wiki article on "Fruchtfolgen" and really many things may be used there (potatoes and chick peas…), so we may have to extend our exclusion list even more… That's getting difficult here. However, some not-so-famous fruits (Ginger, Vanilla, Gooseberries) are likely not used in crop rotation, … *
|
Is not there any farmer with some experience in this field? Not that many on GitHub, probably… 😃 I now added some crop OSM tags missing and the list gets huge. And no, it still does not cover any majority of the top-5 as it differs heavily what is planted per country. My ideas:
BTW: We also more or less already have a whitelist as the |
Actually the definition of an orchard is:
However, the article goes on:
Sure, berries can also be mapped easily… OSM says:
So we need to include fruit gardens.
Good, so no vegetable, nothing growing on ground… (?) |
So final question: Should be only include trees 🌳 ? Or are kiwi 🥝 plantages (does such a thing exist?) marked with "orchard" too? |
Are you asking what would still fall under the OSM In any case, we should assume the following: Anything tagged as The user should be able to give a reasonable answer. How his answer is translated into OSM tags, is another thing. I did not concern myself so much with it (did not read OSM wiki), but I would draw the line between orchard (plantation) and farmland exactly between "cultivated on a yearly or less basis" (farmland) and "cultivated permanently / perennial" (orchard). This would put cotton into the farmland category. |
POE still shows "100%" translated. |
Someone translated it immediately after I added the strings :-D |
I did not do so… 😢 |
Maybe a friendly bot, considering that they are easy to translate… 😉 Could I somehow filter all those belonging to "orchard" to review them? (Maybe using tags, you currently only have a "html" one…) Also it's sad I cannot see any stats, where (these strings) still need to be translated… |
Just go to the last page. If you hover over the values, it should also tell you who did the translation and when. |
Ah, just using the "sort: updated DESC" now. And no I cannot see who did it. Maybe only the admin can see this. |
Okay, review finished. And it was good to review them, some mistakes had to be corrected. And I am a crops pro now… 😜 |
BTW, why are the strings in capital letters? Should not they be in lower case in most languages? |
Current status: Images found, data complete, OSM list changed again, lists regenerated. I also checked, as good as I could, that we have at least images for all result data. TODO: Batch-resize. Also: All translators, please pay attention to the difference between peppers and pipers. See rugk/crops-parser#50 for details. Reminder for @westnordost: Due to splitting of OSM keys, the YAML files may contain more than 15 elements for some countries. Just so you are aware. You can handle this as you want. |
Data changed to use area instead of tonnes. Images resized.
Ah, okay. I basically waited for that PR there. It was blocking that thing a bit. So I just picked the source data as the other part of the PR does not affect StreetComplete/this issue, so the data should be okay now. |
Merged. |
Awesome! 🎉 |
I corrected it in the German translation, but again to emphasize for all translators: |
Huh? What you are saying is wrong. There are the following keys: produce_bell_peppers |
Paprika, Pfeffer, Chilli |
Oh, you actually switched to bell_pepper without any discussion or wiki adjustion? (except of expressing the idea) Okay, your choice/responsibility… Also In any case I'd also like to adjust the image names, as one chooses the wrong one otherwise. |
This is just the key for strings, the exact name of the key does not matter. They reflect how it should be translated. "What is being cultivated here"?
|
Also, I renamed your image names for use in StreetComplete anyway. |
Ah, so it is not the key being put into OSM? |
BTW: Also cannot find |
Sure, also trees are easy to answer. So we would have to let the user between trees and fruits first:
So according to the selection we would have to allow the user to select a type of tree and… seems there are only trees(?).
Or does OSM categorize bushes into the "trees" category too?
The UI could be similar to the one of the street paving.
Edit: We need images for these crops:
The text was updated successfully, but these errors were encountered: