Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use oneway-data from improveosm.org #370

Closed
amilopowers opened this issue Jul 2, 2017 · 25 comments
Closed

Use oneway-data from improveosm.org #370

amilopowers opened this issue Jul 2, 2017 · 25 comments
Assignees
Milestone

Comments

@amilopowers
Copy link

Hello

improveosm.org is an amazing tool to find turn restrictions, oneways, missing roads and so on. It uses metadata from traffic data.

I don't know how hard this would be to implement but I'd love to see if your app could work together with improveosm.

Like this your app could ask questions like "is there a turn restriction from raod x to y?" (maybe with visual support) or is this a one-way restricted road?

I am not a dev so I can't help with implementing.

@chrisdebian
Copy link

This is what I was suggesting, here:

#359

Thanks,

Chris.

@westnordost
Copy link
Member

What is the URL?

@matkoniecz
Copy link
Member

https://improveosm.org/

@matkoniecz
Copy link
Member

missing roads

See https://github.com/westnordost/StreetComplete/wiki/Adding-new-Quests-to-StreetComplete (linked during creating a new issue)

Only existing elements can be extended, no elements can be added or removed.

@chrisdebian
Copy link

Maybe also some crossover with Mapswipe (http://wiki.openstreetmap.org/wiki/MapSwipe) and OpenMapKit (http://openmapkit.org/index.html).

But they could probably gain more from StreetComplete

@westnordost
Copy link
Member

westnordost commented Jul 2, 2017 via email

@rugk
Copy link
Contributor

rugk commented Jul 2, 2017

Like this your app could ask questions like "is there a turn restriction from raod x to y?" (maybe with visual support) or is this a one-way restricted road?

Yeah, I think that's a good example. Maybe you should collect such examples and open new issues with "New quest:" for each of them, so each of these questions can be tracked separately.
You can mention there that osmimprove.org also does it, but the implementation will likely be independent to it. Anyway, it is of course a good source for some ideas… 😄
Of course pay attention to the docs.

Mapswipe

Not really. The purpose of this app is not really to show you satellite images.

OpenMapKit

A library or so, somehow about surveys with OSM. Not sure what this has to do with StreetComplete.

@westnordost westnordost changed the title Work with osmimprove.org Work with improveosm.org Jul 4, 2017
@westnordost westnordost changed the title Work with improveosm.org Use oneway-data from improveosm.org Jul 4, 2017
@westnordost
Copy link
Member

Okay, I looked through the source code of improveosm.org. The only thing that would be usable for StreetComplete would be the "is probably a oneway" detection.

There is an API, but it is not documented.Example call to get all open "direction of flow":

http://directionofflow.skobbler.net/directionOfFlowService/search?format=fjson&south=53.0&north=53.1&west=9.0&east=9.1&zoom=15&confidenceLevel=C1%2CC2%2CC3&status=OPEN&client=WEBAPP&version=StreetComplete%200.11

As far as I can see, the API part of improveosm.org is closed source, so there are a few problems and open questions:

  • the client parameter must always be WEBAPP, anything else is not accepted. This sounds like it is not wanted that other applications use this API
  • a zoom level MUST be specified, depending on the zoom level (and/or density of found road sections), "clusters" are returned. StreetComplete is not interested in clusters, we need the real data. In my test call, starting with zoom level 15, proper data is returned, but:
  • the bounding box is very limited. The exact max bounds are unclear, but it relates to the zoom level.
  • it is unclear whether the API returns results for whole ways (probably not?) or also for way-sections that'd have to be split up. Currently, StreetComplete is not able to split ways up.

@chrisdebian
Copy link

chrisdebian commented Jul 4, 2017 via email

@chrisdebian
Copy link

This is related, so won't open a new ticket.

Can we use the data from Osmose (http://osmose.openstreetmap.fr/en/map/) or KeepRight (https://www.keepright.at/), to help generate quests?

Thanks,

Chris.

@rugk
Copy link
Contributor

rugk commented Jul 8, 2017

Could you please explain what (useful data) these sites provide, which could be used in StreetComplete? And how could it be used?

@westnordost
Copy link
Member

So, no reply from telenav so far. improveosm.org doesn't seem to be still maintained and I don't know any other way to contact them.

@westnordost
Copy link
Member

If anyone wants to follow this further, perhaps here: https://telenav.zendesk.com/

@Binnette
Copy link
Contributor

Note JOSM plugin for ImproveOSM is available here :
https://github.com/Telenav/improve-osm-plugin
May be you can find answer in it.
BTW, i also contact Telenav and ubermih. Waiting for answers...

@tBeata-grab
Copy link

tBeata-grab commented Aug 27, 2017

Hello all, currently the ImproveOSM services are not open sourced, and are consumed only by Telenav projects.
The data from the plugin or iD tool can be used for mapping purposes, furthermore we have some data dumps for the missing roads component that can be found here: http://missingroads.skobbler.net/missingRoadsDumps/.
Since the services are not open sourced (not open for the public), you should send us an email before starting integrating it into your tool.
The email addresses are: beata.jancso@telenav.com and martijnv@telenav.com.

@rugk
Copy link
Contributor

rugk commented Aug 27, 2017

Since the services are not open sourced (not open for the public)

Why are not they?

@westnordost
Copy link
Member

OK, I will send you and email explaining why this project would like to use this data and what requirements would need to be met to properly use the data. Thanks for your answer and thanks @Binnette for taking over to reach out.

@mvexel
Copy link

mvexel commented Sep 1, 2017

Update: @westnordost and I have been in touch and we are exploring the integration. @beataj-telenav is on vacation right now but we hope to check back in in a couple of weeks.

@westnordost westnordost added this to the v4 (planned) milestone Nov 28, 2017
@westnordost westnordost removed this from the v4 (planned) milestone Jan 17, 2018
@westnordost westnordost removed the blocked blocked by another issue label Jun 3, 2018
@westnordost westnordost self-assigned this Jun 3, 2018
@westnordost westnordost added this to the v6 milestone Jun 3, 2018
@westnordost
Copy link
Member

done

@rugk rugk mentioned this issue Jun 30, 2018
@rugk
Copy link
Contributor

rugk commented Jun 30, 2018

Did I miss something or what happened to the "turn restrictions"? Telenav also has some dumps for it and it could be implemented in a similar way.

@westnordost
Copy link
Member

I wrote

Okay, I looked through the source code of improveosm.org. The only thing that would be usable for StreetComplete would be the "is probably a oneway" detection.

in #370 (comment)

Turn restrictions would often involve splitting up the ways. Can't be done in StreetComplete.

@rugk
Copy link
Contributor

rugk commented Jul 1, 2018

Are not turn restrictions just at intersections of ways? Don't see where you need to split a way there. It just needs a quite complex GUI as iD e.g. has:

grafik

(Don't know the details, but for a user it looks just as if you edit the single points, where the streets meet. Technically likely done with something in a relation or so…)

@matkoniecz
Copy link
Member

matkoniecz commented Jul 1, 2018

Don't see where you need to split a way there.

iD editor splits ways to create some restrictions

@rugk
Copy link
Contributor

rugk commented Jul 1, 2018

Okay, mhh… 🤔

@tBeata-grab
Copy link

Telenav suggest possible turn restrictions missing from OpenStreetMap. Editing a turn restriction is indeed a more complex task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants