Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoulder quest only on motorway and trunk in the Netherlands #4617

Closed
A67-A67 opened this issue Nov 6, 2022 · 14 comments
Closed

Shoulder quest only on motorway and trunk in the Netherlands #4617

A67-A67 opened this issue Nov 6, 2022 · 14 comments
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@A67-A67
Copy link

A67-A67 commented Nov 6, 2022

In the Netherlands only motorways and some trunk roads have shoulders, in Dutch: vluchtstrook (fleeing/emergency lane). On primary, secondary and tertiary they are extremely rare. Hence the quest "Add whether there are shoulders" would lead to adding shoulder=no on 99,9% of these roads, which is undesirable. An inquiry with the Dutch community made clear a lot of people agree that this is undesirable.

I'd like to propose enabling this quest only on highway=motorway and highway=trunk in the Netherlands. If this isn't possible, I think it'd be better to disable this quest entirely in the Netherlands.

@A67-A67 A67-A67 added the bug label Nov 6, 2022
@westnordost
Copy link
Member

Are you aware of that also soft shoulders and not only hard shoulders are tagged with shoulder=* in OSM?

I.e. any area next to the roadway that was made with enabling emergency stopping in mind.

In German, those would be called "Bankett" (maybe similar in Dutch).

@westnordost westnordost removed the bug label Nov 7, 2022
@westnordost
Copy link
Member

E.g.

@Geim66
Copy link

Geim66 commented Nov 7, 2022

A shoulder in the Netherlands is a "Vluchtstrook" always a hard shoulder (we know, we invented them: https://nl.wikipedia.org/wiki/Vluchtstrook ). No soft shoulders. Only road, shoulder and verge
Like in this picture
image

@westnordost
Copy link
Member

westnordost commented Nov 7, 2022

You mean

  1. there are never any soft shoulders as depicted in NL, or
  2. if there are any soft shoulders, they are not tagged with shoulder=* in NL?

@Geim66
Copy link

Geim66 commented Nov 7, 2022

Let's say it like this. This road has no shoulder.

image

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Nov 7, 2022
@Helium314
Copy link
Collaborator

Helium314 commented Nov 8, 2022

E.g.

If this really counts as shoulder, shouldn't this count too?

s

@Geim66 one road without a shoulder doesn't mean no road has a shoulder. Could you please explain what you are trying to tell with your comment?

@rhhsm
Copy link

rhhsm commented Nov 8, 2022

The matter seems to be what a "shoulder" is. The wiki states that it is a "lane" that is wide enough to be used as an emergency refuge for cars The photos posted by westnordost and Helium314 show what looks more like a reinforced verge; I think they are not wide enough to be used as an emergency lane so I wouldn't tag them as a shoulder.
Back to the original question, I agree that shoulders are very rare on roads other than trunk and motorway. Maybe that's because I'm also Dutch, but I'm using SC mostly in Bulgaria and Turkey. In Bulgaria (and probably in many other countries) a paved shoulder is a requirement for a road to have motorway status, so asking for it on motorways would result in close to 100% shoulder=yes in those countries.

@westnordost
Copy link
Member

westnordost commented Nov 8, 2022

@Helium314 according to the current wiki wording, your example would not have a shoulder=yes because a car could not completely stop beside the traffic lanes. For my example on the other hand, it could, at least at the area close to the camera - not sure about at where the trees start. Geim66's example looks like it would also fall under the wiki definition of a (soft) shoulder because a vehicle can stop completely beside the traffic lane and on first glance, it seems to be maintained as an emergency stopping lane (plane solid surface of short cut grass without any shrubbery or ditches; clearly demarcated shoulder line some distance from the actual edge of the paved surface).

I recognize that the current wiki definition of shoulder is quite wishy-washy and leaves a lot of room for interpretation. Is something just a well maintained and broad verge? Or a soft shoulder? How to tag (soft) shoulders that are not full-width, like in your example? How to tag shoulders where one part is paved and the rest is just gravel or grass?

It would be a lot easier and clearer, if something would only be tagged as shoulder=yes when there is a full-width hard shoulder, or something. But alas, that's not how the tag is seen to be used in the wild and this is also not the wiki definition. (If I remember correctly, the initial implementation of this quest in StreetComplete did define it like that in the explanatory text, but it was challenged that this would not coincide with the wiki definition in some ticket.)

In any case, StreetComplete issue tracker is not the right place to propose to change the definition or invent new tagging keys.

@matkoniecz
Copy link
Member

On topic of shoulder tag being confusing: I added note to https://wiki.openstreetmap.org/wiki/Key:shoulder#History and posted https://community.openstreetmap.org/t/shoulder-tag-is-confusing/5185 - and disabled this quest for myself.

@westnordost
Copy link
Member

I am contemplating removing this quest until such time as shoulders can be tagged with more precision. What do you think?

@matkoniecz
Copy link
Member

matkoniecz commented Nov 10, 2022

Well, I removed it for myself, as I was unable to confidently answer it.

I think that it sadly is necessary as definition/data is problematic and there is risk that StreetComplete can make it worse or get blamed for it. And there is no real chance that SC will be able to help reaching better definition. And it gets worse as problem is getting investigated in greater detail.

At least data/definition problem was discovered.

Note that outright removal of quest (not just disabling it) requires extra support as otherwise SC will crash at startup.


Once data is well defined, likely using new tag - then this quest can return.

@westnordost
Copy link
Member

Note that outright removal of quest (not just disabling it) requires extra support as otherwise SC will crash at startup.

Why would it crash at startup?

@Helium314
Copy link
Collaborator

If someone has recent edits for the shoulder quest, I would expect this will crash if the quest is removed:

private fun CursorPosition.toElementEdit() = ElementEdit(
getLong(ID),
questTypeRegistry.getByName(getString(QUEST_TYPE)) as? OsmElementQuestType<*>
?: overlayRegistry.getByName(getString(QUEST_TYPE))!!,

@westnordost
Copy link
Member

Thanks @Helium314. I now disabled the shoulder quest completely. Rather than changing ElementEditsDao, I'll just remove all non-uploaded AddShoulder on update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

6 participants