Undo dialog: Make text selectable

[hamishmb]

Use case
After creating a note, I often realise there's more to add - it would be nifty if I could edit the note rather than undoing and retyping it to make my edit.

Proposed Solution
Perhaps not-yet-uploaded notes could be shown over the map in a different colour so they can be tapped again to edit?

EDIT by @westnordost:
Accepted solution is described here: #4924 (comment)

[matkoniecz]

Note that notes can be closed, can receive additional comments but cannot edited once posted. That is how notes are handled in osm.

[Helium314]

As a very low effort semi-solution: the note text in undo dialog could be made selectable

[hamishmb]

Note that notes can be closed, can receive additional comments but cannot edited once posted. That is how notes are handled in osm.

That makes sense. Please note, I'm not suggesting that already-uploaded notes should be editable, just that not-yet-uploaded notes should be.

[mnalis]

As a very low effort semi-solution: the note text in undo dialog could be made selectable

lt would help only with text-only notes, though. If the note had pictures, you'd had to go back and manually retake them...

just that not-yet-uploaded notes should be

I agree, that would be very nice. I don't know how hard it would be to implement, though. It does not sound trivial...

[Helium314]

lt would help only with text-only notes, though. If the note had pictures, you'd had to go back and manually retake them...

Of of the reasons to call it semi-solution. Main other reason is that most users in need of this feature will not discover it on their own.

[westnordost]

Editing notes in the undo menu would be somewhat unexpected / inconsistent UI, IMO. Also, it does not fit into an UX that does not really make a difference between uploaded changes and local changes (though from the technical point of view, there is a massive difference).

So, @Helium314 solution sounds like a good compromise - make the text in the undo dialog selectable. One could also make the other text (e.g. what is tagged) in that dialog selectable. In fact, I did have the same use case as you a few days ago and subsequently tried to implement making the text selectable, but for some reason it did not work, so I didn't invest any more time in this. Whoever wants to try this again is welcome to. I'll rename the ticket accordingly.

[Helium314]

I managed to do it in a test a few days ago, I think it was something like changing

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/screens/main/edithistory/UndoDialog.kt

Line 136 in 06fd4e6

is NoteEdit -> createTextView(text?.let { CharSequenceText(it) })

to is NoteEdit -> createTextView(text?.let { CharSequenceText(it) }).apply { setTextSelectable(true) }
Though maybe the setting selectable could done be in createTextView instead.