-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New quests for staircases #503
Comments
Maybe split into a separate issues? "and how many steps it has" seems to be ridiculous, requires significant efforts for longer ones and give extremely limited benefits (is there even single case of using this data?). |
Who is going to look on his (smartphone) map to find if a staircase has a handrail (and then avoid this staircase)? To me, it sounds like super-unimportant information. Do you know any data consumer that uses this? |
In theory it may be used for routing and 3D rendering. I am not aware about anybody who uses or wants to use this data.
Note "Ramps that run physically separated (e.g. separated by a fence, height difference or wall), should be drawn separately.". There is no defined key to indicate this (maybe ramp=no should be used in such cases? it is not clear). See https://wiki.openstreetmap.org/wiki/Talk:Key:ramp#How_to_tag_for_separately_mapped_ramps |
Not at all. See the wiki page. It actually lists 5 use cases (blind people, bicyclists, 3d rendering, …) and never forget what other use cases might come up when one has enough data in the future…
Indeed it does, but nobody forces the StreetComplete user to solve that quest. In any case, I agree, however, that the step_count quest should have the lowest priority of all staircase quests.
Yeah, could do so, but I thought these 2 or 3 quests are so closely related that it is okay to have one issue for that. |
See above. Actually I've requested way less important quests here and this is IMHO already a good thing. Of course you are unlikely to consume this data manually, but routing engines, 3d models and other stuff can take care of it. |
BTW: Do you never read the wiki page for a quest suggestion before complaining about it? There are exact examples, so hey… |
I was asking about whatever somebody is using this data. This question is not answered on any linked page from what I see. My reaction may be influenced by fact that I recently walked through several highway=steps way, each with 500+ plus steps (though maybe asking that question for very short ways may make sense). |
Okay 500+ steps is crazy (when creating this quest, I mostly thought of some small 5-10 steps, where you then know you can just lift your bike up), but walking them, I think, you can count them quite easily. I think there are some people always doing it when walking staircases. 😉
Still don't understand what you mean. |
This is not an argument (in your favour). I'd rather not spend time on discussing whether or not to include those borderline next-to-irrelevant quests while there are other more important quests to do, really. |
There is no way in the github issue tracker to properly prioritise these things, so I am swamped with a lot of these kind of quest suggestions that block the sight to the actually important ones (such as the building type quest) and give possible contributors the wrong idea about which should be the priorities. This all is a huge waste of time. |
Then leave it open for PRs. This is open-source and also a community project… That's the big advantage of FLOSS software. |
Some projects create tags: "priority:P1", and so on… Maybe do this? Or, if you want to do it easier, just use a "low prio" tag or so… Also I can suggest this: https://github.com/westnordost/StreetComplete/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc (or filter it for only quests) |
Well, it's not about whether I can keep a prioritised overview over the issue tracker but whether contributors can. So this would need to be the default view. Anyway, enough of my whining. For this, as said, |
By tagging issues, contributors see this too.
Really, actually I think this is the property here, which is the most difficult/dubious whether it can be implemented in a good way. See #503 (comment). Actually my priority would be:
Ramps may also be difficult, because there are bicycle ramps, luggage ramps and wheelchair ramps… So mhh… 😐 |
Perhaps the wheelchair-ramp. But the others are fine, IMO |
I have seen some projects with "very low importance" tags like https://github.com/MarcusWolschon/osmeditor4android/issues?q=is%3Aissue+is%3Aopen+label%3A%22Low+Priority%22 |
Exactly, that's what I mean. |
Closing in favor of #875 . |
Does this staircase has:
I know there are few ramps considering all staircases, but as the note from wiki says: "It's equally important to use ramp=no."
This information may useful for people with difficulties passing staircases, blind people, 🚴♂️/🚴♀️…
The text was updated successfully, but these errors were encountered: