Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New quests for staircases #503

Closed
rugk opened this issue Aug 18, 2017 · 19 comments
Closed

New quests for staircases #503

rugk opened this issue Aug 18, 2017 · 19 comments

Comments

@rugk
Copy link
Contributor

rugk commented Aug 18, 2017

Does this staircase has:

  • a handrail? (possibly, if so, where: right or left or both)
  • and how many steps it has (Edit: tracked in Step count quest #875)
  • for wheelchair users and bicycles, maybe again ask for ramp?
    I know there are few ramps considering all staircases, but as the note from wiki says: "It's equally important to use ramp=no."

This information may useful for people with difficulties passing staircases, blind people, 🚴‍♂️/🚴‍♀️…

@rugk rugk changed the title New quest: Staircase things New quest: Staircase Aug 18, 2017
@rugk rugk changed the title New quest: Staircase New quests for staircases Aug 18, 2017
@matkoniecz
Copy link
Member

Maybe split into a separate issues?

"and how many steps it has" seems to be ridiculous, requires significant efforts for longer ones and give extremely limited benefits (is there even single case of using this data?).

@westnordost
Copy link
Member

Who is going to look on his (smartphone) map to find if a staircase has a handrail (and then avoid this staircase)? To me, it sounds like super-unimportant information. Do you know any data consumer that uses this?
Same with steps. Also, steps can be inferred roughly from the length of the way.
Ramp might be slightly helpful for routing applications.

@matkoniecz
Copy link
Member

matkoniecz commented Aug 19, 2017

to find if a staircase has a handrail

In theory it may be used for routing and 3D rendering. I am not aware about anybody who uses or wants to use this data.

ramp

Note "Ramps that run physically separated (e.g. separated by a fence, height difference or wall), should be drawn separately.". There is no defined key to indicate this (maybe ramp=no should be used in such cases? it is not clear).

See https://wiki.openstreetmap.org/wiki/Talk:Key:ramp#How_to_tag_for_separately_mapped_ramps

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

"and how many steps it has" seems to be ridiculous […] nd give extremely limited benefits (is there even single case of using this data?).

Not at all. See the wiki page. It actually lists 5 use cases (blind people, bicyclists, 3d rendering, …) and never forget what other use cases might come up when one has enough data in the future…

requires significant efforts for longer ones

Indeed it does, but nobody forces the StreetComplete user to solve that quest. In any case, I agree, however, that the step_count quest should have the lowest priority of all staircase quests.

Maybe split into a separate issues?

Yeah, could do so, but I thought these 2 or 3 quests are so closely related that it is okay to have one issue for that.

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

Do you know any data consumer that uses this?

See above. Actually I've requested way less important quests here and this is IMHO already a good thing. Of course you are unlikely to consume this data manually, but routing engines, 3d models and other stuff can take care of it.

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

BTW: Do you never read the wiki page for a quest suggestion before complaining about it? There are exact examples, so hey…

@matkoniecz
Copy link
Member

matkoniecz commented Aug 19, 2017

5 use cases

I was asking about whatever somebody is using this data. This question is not answered on any linked page from what I see.

My reaction may be influenced by fact that I recently walked through several highway=steps way, each with 500+ plus steps (though maybe asking that question for very short ways may make sense).

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

Okay 500+ steps is crazy (when creating this quest, I mostly thought of some small 5-10 steps, where you then know you can just lift your bike up), but walking them, I think, you can count them quite easily. I think there are some people always doing it when walking staircases. 😉
In any case easier to count than certain parking areas, maybe… (#502) 😄

I was asking about whatever somebody is using this data.

Still don't understand what you mean.

@westnordost
Copy link
Member

See above. Actually I've requested way less important quests here

This is not an argument (in your favour). I'd rather not spend time on discussing whether or not to include those borderline next-to-irrelevant quests while there are other more important quests to do, really.

@westnordost
Copy link
Member

There is no way in the github issue tracker to properly prioritise these things, so I am swamped with a lot of these kind of quest suggestions that block the sight to the actually important ones (such as the building type quest) and give possible contributors the wrong idea about which should be the priorities.
When a PR comes, I don't want to outright close it just because other quests should be done first. So, I need to review these PRs, comment, request changes, review again and finally pull and/or even help out (i.e. make an icon etc.)

This all is a huge waste of time.

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

Then leave it open for PRs. This is open-source and also a community project… That's the big advantage of FLOSS software.

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

There is no way in the github issue tracker to properly prioritise these things,

Some projects create tags: "priority:P1", and so on… Maybe do this? Or, if you want to do it easier, just use a "low prio" tag or so…

Also I can suggest this: https://github.com/westnordost/StreetComplete/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc (or filter it for only quests)

@westnordost
Copy link
Member

Well, it's not about whether I can keep a prioritised overview over the issue tracker but whether contributors can. So this would need to be the default view.

Anyway, enough of my whining.

For this, as said, ramp as a quest is fine for now.

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

but whether contributors can

By tagging issues, contributors see this too.
And if you want, you can include a link such as this one in your Contributing.md or so… (Wanna PR?)

For this, as said, ramp as a quest is fine for now.

Really, actually I think this is the property here, which is the most difficult/dubious whether it can be implemented in a good way. See #503 (comment).

Actually my priority would be:

  • handrail – easy to answer, fast to answer
  • step_count – easy to answer, possibly takes time (depends…)

Ramps may also be difficult, because there are bicycle ramps, luggage ramps and wheelchair ramps… So mhh… 😐

@westnordost
Copy link
Member

http://devopsreactions.tumblr.com/post/146398379161/when-the-tickets-just-keep-coming

@westnordost
Copy link
Member

Really, actually I think this is the property here, which is the most difficult/dubious whether it can be implemented in a good way. See #503 (comment).

Perhaps the wheelchair-ramp. But the others are fine, IMO

@matkoniecz
Copy link
Member

I can keep a prioritised overview over the issue tracker but whether contributors can

I have seen some projects with "very low importance" tags like https://github.com/MarcusWolschon/osmeditor4android/issues?q=is%3Aissue+is%3Aopen+label%3A%22Low+Priority%22

@rugk
Copy link
Contributor Author

rugk commented Aug 19, 2017

Exactly, that's what I mean.

@westnordost
Copy link
Member

Closing in favor of #875 .
Wheelchair ramps are often/usually/sometimes and should be mapped seperately which would be difficult to exclude (because it is not even properly defined what/how this is going to be tagged in the wiki). All other ramps are too rare to ask about them specifically, IMO.

mscherer pushed a commit to mscherer/StreetComplete that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants