Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddCrossingType should provide an answer option to remove highway=crossing #5056

Closed
i-ky opened this issue Jun 7, 2023 · 14 comments
Closed
Labels
feedback required more info is needed, issue will be likely closed if it is not provided

Comments

@i-ky
Copy link

i-ky commented Jun 7, 2023

Use case
I see quite a lot of places, where StreetComplete asks about crossing type, where highway=crossing was added by mistake (for various reasons).

Proposed Solution
There should be an answer option like "This is not a crossing at all", which would remove highway=crossing tag. This would be similar to how surface quality quests allow stepping back and fixing surface type if it was mistagged.

@matkoniecz
Copy link
Member

matkoniecz commented Jun 7, 2023

In such case you may leave note or edit with Vespucci.

Note that in case crossing highway=footway is mapped removing highway=crossing is only part, in some cases you rather need to remove invalid intersection (just today I made https://www.openstreetmap.org/changeset/137051170 in such situation - see https://www.openstreetmap.org/node/10785298782/history )

@i-ky
Copy link
Author

i-ky commented Jun 7, 2023

Adding a note is an option, yes. But a shortcut would definitely be useful in my area.

@westnordost
Copy link
Member

Why does "unmarked crossing" not fit in your area? Can people not cross there? Do you have an idea why highway=crossing was added in the first place?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Jun 8, 2023
@eginhard
Copy link
Contributor

eginhard commented Jun 9, 2023

This would be very useful indeed. iD used to automatically add highway=crossing when connecting footways to driveways, which is quite different from unmarked crossings across a street. In areas where separate sidewalks were mapped with iD, this occurs every few meters, so creating notes is not very practical.

@westnordost
Copy link
Member

This is why StreetComplete does not ask any details on a highway=crossing when a driveway is involved:

private val excludedWaysFilter by lazy { """
ways with
highway = service and service = driveway
or highway and access ~ private|no
""".toElementFilterExpression() }

@i-ky
Copy link
Author

i-ky commented Jun 11, 2023

Why does "unmarked crossing" not fit in your area? Can people not cross there? Do you have an idea why highway=crossing was added in the first place?

Unmarked crossings have their own place in my area and I do not object to them in general.

People can cross there, but these places are not perceived as crossings. The picture StreetComplete has for crossing "Without road markings" features kerbs and road, that is visually distinct from footway. Places I am talking about feature uninterrupted footway/sidewalk, no kerbs, no infrastructure usually associated with crossings. Pedestrians have priority over crossing vehicles there, vehicles crossing are a rare event, etc.
https://www.mapillary.com/app/?lat=56.960929458401&lng=24.151530847368&z=19.9&pKey=199315072080266&focus=photo

I have no idea why highway=crossing is there in the first place. It could be iD, it could be StreetComplete in combination with mistagged road/footway (e.g. highway=service missing service=driveway or sidewalk tagged highway=footway instead of highway=sidewalk). But the result is that over time they tend to snowball into unmarked crossings with no island, no traffic lights and no tactile paving, all explicitly tagged while there is literally no chance of such infrastructure being installed there, ever.

@eginhard
Copy link
Contributor

This is why StreetComplete does not ask any details on a highway=crossing when a driveway is involved:

private val excludedWaysFilter by lazy { """
ways with
highway = service and service = driveway
or highway and access ~ private|no
""".toElementFilterExpression() }

I see. After checking, the larger clusters of such cases that I saw were from before this line was added. Recently, I had a couple of instances again, so I didn't think anything in StreetComplete changed, but these turned out to be crossings over other service roads. It could still be a useful option, but probably not that important with the driveways already ignored.

@matkoniecz
Copy link
Member

matkoniecz commented Jun 13, 2023

https://www.mapillary.com/app/?lat=56.960929458401&lng=24.151530847368&z=19.9&pKey=199315072080266&focus=photo

That is service=driveway right? In such case leaving note (especially with a photo) increases chance of this mistake/omission being fixed.

(though highway=crossing is not strictly wrong there anyway)

@i-ky
Copy link
Author

i-ky commented Jun 13, 2023

https://www.mapillary.com/app/?lat=56.960929458401&lng=24.151530847368&z=19.9&pKey=199315072080266&focus=photo

That is service=driveway right? In such case leaving note (especially with a photo) increases chance of this mistake/omission being fixed.

(though highway=crossing is not strictly wrong there anyway)

It is tagged highway=service + service=parking_aisle.

@matkoniecz
Copy link
Member

then maybe also service=parking_aisle should be excluded in

@i-ky
Copy link
Author

i-ky commented Jun 13, 2023

Found this in OSM Wiki:

In areas where sidewalks are mapped as separate geometries, it is commonly seen that every node at which a sidewalk crosses a road, an unmarked crossing is added. So this is something to look out for as data consumer, crossings tagged like this often do not have any recognizable structural measure that deserve to be called a dedicated crossing.

Poor data consumers... If the consensus is to keep this situation as it is now, feel free to close the issue.

@westnordost
Copy link
Member

westnordost commented Jun 13, 2023

I think I wrote that. IIRC I documented what data consumers have to expect (with the current data being heavily influenced by the behavior or iD to add highway=crossing on any intersection of footway with a road).

What data consumers have to expect is not necessarily the best practice in tagging.

But anyway, I guess, setting highway=crossing and specifying the type of "intersection" in cases like this...

image

... is the only way to eventually add kerb=no to adequately describe this situation because kerb is defined as a property of barrier=kerb or highway=crossing and should not be set on intersection nodes without any other tags. (StreetComplete used to do that but now does not anymore after extensive feedback and discussion on the forum https://community.openstreetmap.org/t/improving-the-wiki-documentation-of-barrier-kerb-and-kerb/97042 )

@westnordost
Copy link
Member

So, indeed, I will close this issue.

By the way, I think no quest exists yet that asks for the type of kerb on highway=crossing nodes, maybe there is already a ticket for that. If not, it could be proposed.

@westnordost westnordost closed this as not planned Won't fix, can't repro, duplicate, stale Jun 13, 2023
@arrival-spring
Copy link
Contributor

By the way, I think no quest exists yet that asks for the type of kerb on highway=crossing nodes, maybe there is already a ticket for that. If not, it could be proposed.

It exists, see #3239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback required more info is needed, issue will be likely closed if it is not provided
Projects
None yet
Development

No branches or pull requests

5 participants