Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerbs for existing crossings #3239

Closed
davidpnewton opened this issue Sep 1, 2021 · 14 comments · Fixed by #5104
Closed

Kerbs for existing crossings #3239

davidpnewton opened this issue Sep 1, 2021 · 14 comments · Fixed by #5104
Assignees
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)

Comments

@davidpnewton
Copy link

In the most recent beta 34.0 #2999 is fixed. That means crossing nodes are added for non-crossing type ways meeting a highway. The quests which trigger then involve saying whether the crossing has an island, what type of kerbs it has, what type of crossing it is and whether it has tactile paving.

Three of those four quests also trigger for crossing nodes on crossing ways where they meet highway ways. However the quest to set a kerb type on this crossing node never triggers. To me this should trigger for all highway=crossing nodes, regardless of whether they are for a crossing type way meeting a highway type way or for a non-crossing type way meeting a highway.

@westnordost
Copy link
Member

Sorry, I have difficulties to understand what you mean.

Do you mean to say that for crossings that are already tagged with highway=crossing, the app should also ask for its kerb (height)?

@davidpnewton
Copy link
Author

You have difficulties. However you understand correctly. For nodes already tagged with highway=crossing the app should ask for the type of kerb.

@westnordost
Copy link
Member

Hmm, I guess this would be possible. It would be a separate quest though.

@westnordost westnordost added the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Sep 6, 2021
@westnordost
Copy link
Member

And it should not be asked for crossing nodes that are part of a highway=footway + footway=crossing

@Lee-Carre

This comment has been minimized.

@westnordost

This comment has been minimized.

@davidpnewton

This comment has been minimized.

@westnordost

This comment has been minimized.

@davidpnewton

This comment has been minimized.

@westnordost

This comment has been minimized.

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Sep 9, 2021
@davidpnewton

This comment has been minimized.

@westnordost

This comment has been minimized.

@westnordost westnordost removed the new quest accepted new quest proposal (if marked as blocked, it may require upstream work first) label Sep 19, 2021
@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 3, 2021
@westnordost
Copy link
Member

So, we may have misunderstood each other, but what would be viable as a quest from a rough look at it would be the following:

For highway=crossing that are tagged on a road-way and do not intersect with any footway which may indicate the crossing to be mapped in more detail (i.e. with footway=crossing + highway=footway), we can ask about the kerb height and tag this information onto the highway=crossing node.

The current kerb height quest looks to tag the kerb height information on the barrier=kerb nodes. A proposed quest could also tag the kerb height information on the highway=crossing node but should only do this if the barrier is not already tagged (or taggable) on the barrier=kerb nodes) because the latter is more detailed.

@arrival-spring
Copy link
Contributor

This quest would have a problem if there is a different kerb on each side of the crossing.

I asked on the forum and the only solution is to leave a note (with photo) in that situation, for the crossing to be mapped in more detail later.

This should be rare enough that it is not a blocker though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new quest accepted new quest proposal (if marked as blocked, it may require upstream work first)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants