No -1 in the world after log-in

[DoggoOfSpeed]

I changed the username, password and email address of my osm account and after logging in with the new info the app claims that I'm number -1 in the world (which is a pretty bad place to be imo)

How to Reproduce
Change your OSM profile so that you have to renew your StreetComplete log-in.

Log-in to street complete

Expected Behavior
I am placed where I should be

Versions affected
53.2

[westnordost]

Well, you are even in front of the first guy, you are so lucky! ;-)

[westnordost]

What is your OSM username?

[westnordost]

How to Reproduce
Change your OSM profile so that you have to renew your StreetComplete log-in.
Log-in to street complete

Cannot reproduce.

[DoggoOfSpeed]

Hmm... After some time it has gone normal. Should I close the issue?

[westnordost]

So, the rank can be -1 if not determined yet (server-side) and also not set yet locally. And this rank is unconditionally written into the text field.

However, the item is made invisible if the rank <= 0. So, I have no idea how this is possible. Maybe something to do with animations (being off on your device?), but I just checked that too, still not reproducible.

So at the moment I just assume it is some bug in the Android API on the distribution used on your particular device 🤷 and I do not really want to implement workarounds for such assumptions, so I'd indeed close this. If this happens for other people too, it could be revisited.

For the record, what's your Android version and device name?

[tapetis]

I also had this happen to me once. It is likely related to an animation running on the text view when the local stats with rank -1 are displayed after login, while at the same time new stats are retrieved from the server with a rank > 0 that make the surrounding container visible again. As the previousRank is not cleared on logout, an animation is started even when the local rank is -1, but the next update is not animated as previousRank <= 0 is true in this case. The animation to value -1 may thus complete after the text view was set to display the correct rank.

In the following code snippet, it is therefore probably best not to execute the code after the isGone call at all, unless the container is actually visible.

StreetComplete/app/src/main/java/de/westnordost/streetcomplete/screens/user/profile/ProfileFragment.kt

Lines 244 to 254 in 3370c29

	container.isGone = rank <= 0 || statisticsSource.getEditCount() <= 100
	val updateRank = { r: Int ->
	circle.text = "#$r"
	circle.background.level = getScaledGlobalRank(r)
	}
	if (previousRank <= 0 || previousRank < rank) {
	updateRank(rank)
	} else {
	animate(previousRank, rank, container, updateRank)
	}

[DoggoOfSpeed]

For the record, what's your Android version and device name?

Android 11, Samsung Galaxy S6 and my OSM nickname is leekleak (also, sorry for the late reply 😓)
(oh, and -1 is a pretty bad place to be because in python the index -1 refers to the last element of the array)