-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Bollard" is called "Bollard Row" #5549
Comments
The issue is that iD presets distinguish nodes and vertices (= nodes of ways) while StreetComplete (doesn't have the data model to) distinguish these. So, when looking which StreetComplete/app/src/main/java/de/westnordost/streetcomplete/util/ktx/FeatureDictionary.kt Lines 13 to 14 in 4435ec4
Since changing the whole data model is out of the question, to be honest, I am unsure how to solve this. |
If SC doesn't pull directly from the presets and it can be manually adjusted, could this be labeled "Bollard(s)" and equivalents in different languages? |
It does pull directly from the presets. |
Maybe we can prefer Node over Vertex over anything else? |
How to Reproduce
Select an instance of the quest "What kind of bollard is this?". You will be asked "What kind of bollard is this?", and in the object description, the bollard will be called "Bollard Row". Other bollards in the vicinity will also have the bollard row icon.
Expected Behavior
The bollard will be called bollard and other bollards will have the bollard icon.
Additional info
barrier=bollard
is somewhat special in that it should receive different names depending on how it is used. A node withbarrier=bollard
should be called "Bollard" (also if it is a node that is part of a way). But a way itself with the tag should be called "Bollard Row"id-tagging-scheme
, but ID will correctly call a node "Bollard" and a way "Bollard Row"barrier=bollard
that is part of the way is the same as beeing the way that has the tag and so thinks bollard row is the appropriate string.Versions affected
Observed in v57.1
The text was updated successfully, but these errors were encountered: