Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Bollard" is called "Bollard Row" #5549

Closed
wielandb opened this issue Mar 24, 2024 · 4 comments
Closed

"Bollard" is called "Bollard Row" #5549

wielandb opened this issue Mar 24, 2024 · 4 comments
Assignees
Labels

Comments

@wielandb
Copy link
Contributor

How to Reproduce
Select an instance of the quest "What kind of bollard is this?". You will be asked "What kind of bollard is this?", and in the object description, the bollard will be called "Bollard Row". Other bollards in the vicinity will also have the bollard row icon.

photo_2024-03-24_01-18-45 photo_2024-03-24_01-18-47

Expected Behavior
The bollard will be called bollard and other bollards will have the bollard icon.

Additional info

  • barrier=bollard is somewhat special in that it should receive different names depending on how it is used. A node with barrier=bollard should be called "Bollard" (also if it is a node that is part of a way). But a way itself with the tag should be called "Bollard Row"
  • I noticed this first in the german translation, but it's the same in english, so I don't think it's a problem with the translations
  • I thought it may be a problem in the id-tagging-scheme, but ID will correctly call a node "Bollard" and a way "Bollard Row"
  • My best guess is that maybe SC incorrectly thinks a node that has barrier=bollard that is part of the way is the same as beeing the way that has the tag and so thinks bollard row is the appropriate string.

Versions affected
Observed in v57.1

@wielandb wielandb added the bug label Mar 24, 2024
@westnordost
Copy link
Member

The issue is that iD presets distinguish nodes and vertices (= nodes of ways) while StreetComplete (doesn't have the data model to) distinguish these. So, when looking which Feature matches a set of tags on an element and the element is of type Node, it does not constraint the search to only nodes, because the given Node could be a vertex, too

// only if geometry is not a node because at this point we cannot tell apart points vs vertices
val geometryType = if (element.type == ElementType.NODE) null else element.geometryType

Since changing the whole data model is out of the question, to be honest, I am unsure how to solve this.

@pkoby
Copy link

pkoby commented Mar 24, 2024

If SC doesn't pull directly from the presets and it can be manually adjusted, could this be labeled "Bollard(s)" and equivalents in different languages?

@westnordost
Copy link
Member

It does pull directly from the presets.

@matkoniecz
Copy link
Member

So, when looking which Feature matches a set of tags on an element and the element is of type Node, it does not constraint the search to only nodes, because the given Node could be a vertex, too

Maybe we can prefer Node over Vertex over anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants