-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect tagging for maxspeed:type in the UK #5592
Comments
Actually But otherwise it's on the user. If the user answers it's a zone with 19 kmh limit, then SC will tag |
Sorry, missed a : in there. Actually, if a user types in 19, a message will come up saying "Are you sure? This speed limit looks implausible", so there is a level of prevention that needs to be applied to the 30 value, just with a different message perhaps - users may not understand exactly how 30 mph speed limits should be tagged |
Could you link to some of the changesets in question? Have you already asked the user about this? |
note that 30 in such case would be wrong only in UK is it problem with single user? or more wide? |
This is not a bug. It is what the user(s) selected. The following video shows what the user has to select and input in order for this to be tagged: Maxspeed.mp4I.e. the users answered that it is within a slow zone and a picture of the sign was shown for them to input what they see on that sign. |
Yes, I understand the process works as intended, but that should not be the case as a 30 zone does not exist in the UK. Only the tags |
So, you would like us to add a sanity check alike the "this speed limit looks implausible, are you sure?" in regards to slow zones. How do you think such a check should look like? |
Something along the lines of "Are you sure this is a speed limit zone? Please check you can see a speed limit zone sign"? |
I meant, when should this warning appear? Under which circumstances / given which user input?
El 24 de abril de 2024 11:22:47 CEST, Nathan Acheson ***@***.***> escribió:
…Something along the lines of "Are you sure this is a speed limit zone? Please check you can see a speed limit zone sign"?
--
Reply to this email directly or view it on GitHub:
#5592 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
Well 30 is likely the most common mistake due to the way 30 mph speed limits work in the UK. A message for that input should be fine. |
Well, we need to think worldwide, because the quest is available worldwide. And surely, the same message should also be shown for an input of 31, 40 etc., no? |
Well, those are likely mistakes, whereas the 30 zone tag has been applied by multiple people, showing a bigger issue. I think the "Are you sure?" message covered by strange numbers is fine for the other values, it's just the 30 that appears to be the issue. |
But an input of 30 should not lead to a warning message everywhere in the world, right?? |
Well, this is only an issue in the UK |
Sigh... it seems I fail in bringing across what I want from you. I am not going to add special rules in the code for every single country code, like Anyway, I can think of something myself, but then I would like to know from you why especially the input of 30 is that common of a mistake in the UK? You started changeset discussions on some of these changesets, so hopefully the users will be able to answer this. |
@westnordost alright, what about adding a positive list for existing zones per country and warn if the user inputs something else? There's the default speed limit article which is supposed to be machine readable in the OSM wiki. I think it could be extended to list the zones in each country (or this could be added in some other article) and imported into SC while creating a new version. This way there's no need to maintain this data in SC. |
Maybe it can go into country data? And if there is list defined complain about ones outside the list. |
That sounds like a huge effort for a small "Are you sure?" dialog. (Not only initial, but also continuous - maintenance.) Also, what hinders road authorities to come up with new limits for speed signs on the spot? 30kmh zone is well known, but I don't see a reason why there shouldn't be a 20kmh zone, a 10 kmh zone, a 15kmh zone, etc. |
Yeah sure, but that would need continuous maintenance, compared to a wiki approach where people would maintain it for you. |
Germany already got 20 km/h zones... and there were 10 km/h 😇 |
Perhaps I am misunderstanding, but how would that specific wiki page help @RubenKelevra ? That page says it is about "Legal default speed limits apply if no explicit speed limits are set by appropriate signs". I.e. what is default speed limit for urban, rural, motorway etc. road if no sign is present. If some kind of speed limit sign is present (i.e. For example, when I count different And when I count different Better automated solution might IMHO be that on-new-release we build a list of allowable
Also, perhaps it might be useful to actually contact those users who mapped wrong non-existent values (esp. if they same user did that same error several times or more) and check with them why it might be happening? Sure, fat fingers are one explanation, but there might be others... |
All those listed there, except
I did contact those who made the mistakes but the only reply thus far is a comment linking to this exact thread. |
Ok, let's wait a bit. Did you actually ask them or have a hunch why they answered this way? |
I suspect because it's somewhat common to say "30 zone" to refer to general widespread 30 mph speed limits in the UK, and so these users selected the zone sign when answering the quest as a result. I didn't actually ask each user why they made this mistake, just a general comment on how to correctly tag such limits. I will add a question onto the end of each changeset |
Are these "30 zones" signed in some way or are they set implicitly by the presence of street lighting? |
Many of the incorrect tags were applied to 30 mph speed limits where there are no repeater signs due to the presence of street lights (where the correct tag is |
So, would changing the wording to "It's within a signed (slow) zone" make it clear? |
Potentially |
I implemented showing a warning on entering a not-really-slower-than-normal speed limit in the slow-zone sign input, also shown for odd values such as "17" etc. |
The wording change was reverted in b89db4a. |
because looking at the translations, some are already a bit awkward, with that "(slow)" in there. Adding another adjective will result in even more awkward wording for some translations that may end up being confusing. |
I've seen a few changesets where a user has answered the speed limits quest, and the tag
maxspeed:type=GB:zone30
has been applied to the map. This tag is incorrect as 30 zones do not exist in the UK, only 20 zones and 40 zones. Users should be prevented from inputting any values other than 20 or 40 to answer speed limit quests in the UK with a speed limit zone.The text was updated successfully, but these errors were encountered: