Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login or authenticaton should be more userfriendly and clear #593

Closed
hoergen opened this issue Sep 15, 2017 · 13 comments
Closed

Login or authenticaton should be more userfriendly and clear #593

hoergen opened this issue Sep 15, 2017 · 13 comments
Assignees

Comments

@hoergen
Copy link

hoergen commented Sep 15, 2017

The authorization process is kinda complicated, even if you are technical interested person. I already had a OSM account, but I needed 8-9 tries before i could authorize my account with this wonderful App.

Is there a way that you just can put in the two fields "username" and "password", so that not so technical persons just have a clear vision, what they have to do?

Or add some more explanations, what you have to do with that authorization process? Like "It opens your browser and then login there. After it is successful, it will guide you back to your app" or something like this.

I have installed the OSM App on my phone and my phone gave me the options to open a browser or the OSM app and because I came from StreetComplete I opened the OSM app several times, which was very logical for me. But this was a dead end, what I didn't understand until someone helped me to try the other way with the browser.

@westnordost
Copy link
Member

What is an "OSM app"?

@hoergen
Copy link
Author

hoergen commented Sep 15, 2017

OpenStreetMap is called in the store OSM.

@westnordost
Copy link
Member

If you mean OsmAnd, OsmAnd is not the official OpenStreetMap app. The website and the app has no affiliation to each other whatsoever.

@hoergen
Copy link
Author

hoergen commented Sep 15, 2017

Ok sorry, that I missunderstod that. But I think many others do the same mistake.

@westnordost
Copy link
Member

So, your assumption is wrong. OsmAnd is not to OpenStreetMap what the Youtube app is to the Youtube website, it is a completely different app. Supposing there were a MyVideoDownloader app that would offer itself to open youtube.com links, you wouldn't assume that this app would be the "app version" of Youtube, would you?
If anywhere, the error is OsmAnd's name choice for creating such misunderstandings and their aggressive registering of URLs.

I opened an issue in their tracker. osmandapp/OsmAnd#4440 Let's see what comes of it.

This is not an issue of this app, any app that needs OAuth permission from openstreetmap.org will have the same problem.

@westnordost
Copy link
Member

Is there a way that you just can put in the two fields "username" and "password", so that not so technical persons just have a clear vision, what they have to do?

This would defy the meaning of using OAuth at all. The reason to use OAuth is that the user doesn't need to give his (OSM) credentials to any such app/website/service but can authorize the app to have a revokable access to his profile there - without knowing the password.

@westnordost
Copy link
Member

However, if this persists to be a problem (Osmand team does not want to do anything about it), I might come back to this and be forced to add some kind of dialog in between that announces that the user now needs to authorize the app in the browser.

@hoergen
Copy link
Author

hoergen commented Sep 15, 2017

I think it would help to put a help text like I described, so that nobody else is tapping into that trap , like I did ;)

@westnordost
Copy link
Member

westnordost commented Oct 1, 2017

I fear this issue needs to stay open until Osmand team did something about it or I, with a warning.

@westnordost westnordost reopened this Oct 1, 2017
@smichel17
Copy link
Member

Regardless of what happens with osmAnd, I don't think it will be sufficient, since they are not the only ones who may register this url (for example, addressToGPS also does this).

However, I don't think you need to go as far as a popup. Just modify the "Not yet authorized" string to something like "Log in from your web browser to authorize."

@westnordost westnordost self-assigned this Oct 8, 2017
@westnordost
Copy link
Member

I think I will add a dialog in between, that explains that a browser will open etc.

@westnordost
Copy link
Member

I now created a PR at OsmAnd at osmandapp/OsmAnd#4584 to fix this issue.

westnordost added a commit that referenced this issue Oct 13, 2017
… starting it (#593)", instead implement solution suggested by smichel17
@westnordost
Copy link
Member

@smichel17 I misunderstood your suggestion first. Implemented it now like you suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants