Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycleway quest: Don't ask for cycleway with separately mapped sidewalk #718

Closed
westnordost opened this issue Dec 8, 2017 · 15 comments
Closed
Assignees

Comments

@westnordost
Copy link
Member

The app currently does not ask is users for the existance of a cycleway if a separately mapped cycleway exists in the vicinity.
However, it should also not ask if that separately mapped way is a sidewalk only (without cycleway).

@westnordost westnordost added the bug label Dec 8, 2017
@matkoniecz
Copy link
Member

matkoniecz commented Dec 14, 2017

However, it should also not ask if that separately mapped way is a sidewalk only (without cycleway).

What is the reason for that? I am unable to imagine situation where not skipping such cases would qualify as a bug.

@rugk
Copy link
Contributor

rugk commented Dec 14, 2017

I think he also wants to exclude the quest when "footways" (no bike!) are nearby.

This would mean if a "footway" is there, no cycleway can be on/at the street. But why not? (Pedestrians often get better "treatment" than bikers, so it is not an unlikely case that there is a footway and a cycleway on or at the street) I think this is definitively possible, so I agree to @matkoniecz .

@westnordost
Copy link
Member Author

westnordost commented Dec 15, 2017 via email

@rugk
Copy link
Contributor

rugk commented Dec 15, 2017

You may also ask it there, but in any case the result can still be "No this is a footway, but there is a cycleway on the street nearby.".

@matkoniecz
Copy link
Member

matkoniecz commented Dec 15, 2017

Because if a way, be it cycleway or footway (sidewalk) is mapped separately, it means that whether there is a cycleway or not should be asked for that separate way, not for the street.

  1. There are many cases where street itself has cycleway property and separate footway not (contraflow lanes etc)

  2. It is completely OK to put cycleway tag on a road, also if sidewalk is tagged separately (cycleway=lane/track/opposite or using SC style tagging cycleway:both=lane/track, cycleway:left=opposite, cycleway:left=opposite_lane )

@westnordost
Copy link
Member Author

westnordost commented Dec 15, 2017 via email

@rugk
Copy link
Contributor

rugk commented Dec 15, 2017

but every kind of cycleway that is beyond the curb (track, shared sidewalk, etc) should be mapped on that separate way, if the sidewalk is mapped separately

Actually that rather means the footway is already mapped wrongly, because only when it is really separated (by trees or so) it should be mapped separately.

@westnordost
Copy link
Member Author

Well, I agree with you there, though I know that this opinion is not shared by everyone - I think i.e. @matkoniecz would object.

But anyway, that is beyond the argument - if the sidewalk/footway that runs parallel to the street is mapped separately, then if the cycleway is not on the street (lane, bus lane, shared lane,...), it should be tagged as a property of that separate way, not as a property of the street.

Now, to conclude, the app can of course not know beforehand, whether the user is going to select something like lane ( -> tag on road) or something like track ( -> tag on separate way) and thus there is a chance that the app will tag the property on the wrong element (i.e "track" on the road when a separately mapped sidewalk exists).
To eliminate this, the app needs to be more defensive in for what elements the app shows the quest.

@matkoniecz
Copy link
Member

should be mapped on that separate way, if the sidewalk is mapped separately

I encountered this kind of tagging before and while suboptimal I would not describe it as wrong - and I think that it is better that no tagging of cycleway at all (but obviously it is not my decision, I am not one that gets all complaints about poor edits made using app)

@westnordost
Copy link
Member Author

westnordost commented Dec 16, 2017 via email

@westnordost westnordost self-assigned this Jan 3, 2018
@westnordost
Copy link
Member Author

Hmm, actually, I think you are right, @matkoniecz . In the described case, tagging on the road instead of the separate way is perhaps suboptimal - as suboptimal as tagging "13-17" as a housenumber on a building with several entrances - but not wrong and definitely adds information.

So, I will not do anything here.

@westnordost westnordost added wontfix idea rejected because it is out of scope or because required work is not matching expected benefits and removed bug labels Jan 3, 2018
@westnordost westnordost removed the wontfix idea rejected because it is out of scope or because required work is not matching expected benefits label Jan 6, 2018
@westnordost
Copy link
Member Author

Further thought about that.
Actually, it is still a problem, @matkoniecz . The user may answer "cyclists share the sidewalk", then sidewalk=X is tagged on road, which would be wrong if there is a separately mapped way.

@westnordost westnordost reopened this Jan 6, 2018
@westnordost
Copy link
Member Author

So, I wonder, @matkoniecz , do you have an idea what we could do? Otherwise, I guess I must disable the quest for seperately mapped sidewalks.

@matkoniecz
Copy link
Member

What may happen:

  • there is a separately tagged sidewalk, not tagged as available for bicycles
  • there is road without cycleway info
  • sidewalk is available for cyclists

https://github.com/westnordost/StreetComplete/blob/3d0a08bf274297fc25b0e94c87b0f8c7651810dd/app/src/main/java/de/westnordost/streetcomplete/quests/bikeway/AddCycleway.java#L137 is applied

road ends with cycleway=no, sidewalk:X:bicycle=yes, separately tagged sidewalk is not modified

While this tagging is a bit weird - I personally think still the same about situation:

I encountered this kind of tagging before and while suboptimal I would not describe it as wrong - and I think that it is better that no tagging of cycleway at all (but obviously it is not my decision, I am not one that gets all complaints about poor edits made using app)

I may ask on tagging list if asking others would be a good idea.

@westnordost
Copy link
Member Author

westnordost commented Jan 14, 2018

You can do that. But I am pretty sure that in the strict sense, it is definitely wrong. Question is perhaps, how strict we [the community] wants to be.

In the meantime, I disable it.

matkoniecz added a commit to matkoniecz/Zazolc that referenced this issue Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants