-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new quest to determine the tracktype #959
Conversation
Actually, I made an icon specifically for that, it's the tractor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few points:
- Whoa, how did you scale those, with MSPaint? Looking especially at tracktype 2,3 and 4 it really does not look so pleasant
- On the pictures, the very much most important part of this quest:
- track1 shows too much sky and too little of the track. I cannot really identify the surface
- track2 looks kind of less smooth than 3, where should be the tangible difference between these?
- track4 is bad, it should have the same appearance (minus the track) than the other pictures, not this red-brownish heathlands
Uhh? I actually correlate this icon used here much more with "track/way surface" than a tractor. A tractor may be about agriculture, so a quest about plants on a field or whatever. (I know, not a quest we want.) And if you considered to use the tractor for that, what did you want to do with this icon? |
This was my tool/website which did this 😄 I fear this needs some adjustment...
I also thought that this icon would fit a little bit better... Regarding the images: I will look for some better ones that will fit your proposals. |
|
Mmh... Alright. I find this still a little bit confusing. |
Mhh ok. Considering the asked question, maybe the icon should try to represent quality somehow? Some +/- signs, 👍/👎 or so (in a simplified way) or so on a street, maybe? |
Rather than quality, I suggest firmness. |
Maybe this is just because of the bad quality of the images, but I think grade2 is something like gravel and grade3 is sand or something softer... |
maybe this one is better? |
Maybe it would be better if it had been photographed from an even lower position (i.e. frog perspective, but not looking up, but just straight on the road). Then you can also see more details of the surface itself. BTW I also just noticed the question is a bit odd. "What is the quality?" -> "Soft". |
It would be ideal to have the different photos more or less show the same scene and in the same perspective but only have the track types differ. If on one photo, there is a forest but on the others, there are just meadows and shrubbery, people might be confused that this photo should be selected for tracks in a forest. |
I changed the icon to the tractor now because the ways are mainly used by them. So it makes kinda sense to show it... |
Only the bad ones, i.e. the ones with the bad quality. As this quest also can be answered with good quality/asks about the type in general, this argument makes no sense. |
Well but for example the ways are allowed for (in German) "Land- und Forstwirtschaftliche Fahrzeuge" which implicites tractors... And I know also some tracks with a good surface quality like asphalt which can be used by tractors... I don't know which icon is the better one... |
Here would be some more pictures that might fit: #133 (comment) |
…cause some renderers need that information
I replaced the images of grade1, grade2 and grade4 with some of the images made by @BjornRasmussen in #133 (comment) |
Nice use of the images! |
I'm not really sure if you released all images under the under the CC BY 4.0 license or only the images used for the path surface quest... Because I only found this comment where you stated that 6 images can be used but 2 of the images I used were mentioned earlier above and not in that comment. Would it be possible that you maybe release https://drive.google.com/file/d/1VzhiJin8IUIMFnQzOLeyDurttyeVPnbuXA/view and https://drive.google.com/file/d/1RJn5CW_AijVCWWtQ_cKHXmGFksTZ2ua9SQ/view under the same license too? |
Sure. |
The pics are really good now! |
Maybe you can exclude tracks already tagged with "surface=asphalt" (if that is a thing/happens for "highway=track"), as there the track type value is quite obvious, it's level 1 and one would not need to ask a surveyor about that. As for the images, yes, they show what we want, but what catches my eye first are actually the differences between the images regarding whether there are trees at the left/right. 😢 |
This PR adds a new quest for determining the surface quality of a track. It fixes #487.