stop timeouting after 45 seconds [ready for review] #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
default overpass timeout is 180 seconds should fix streetcomplete#1010, may help with streetcomplete#1466
|
If it fixes #1010 maybe we can re-enable integration tests for CI? (AFAIK they were disabled, because of that issue.) |
|
Nope. See log of CI tests, startup of emulator was failing. |
westnordost
reviewed
Jul 6, 2019
|
AddBusStopName is quite expensive, because of the |
|
PR: Makes sense, if the default Overpass timeout is that long! |
matkoniecz
changed the title
westnordost
approved these changes
Jul 7, 2019
This was referenced Jul 14, 2019
After update to LOS 16, no quests are loaded via WiFi, only sometimes it works via mobile data
#1466
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
default overpass timeout is 180 seconds
should fix #1010, may help with #1466
Construction tests started failing in a new way, but quest download already works nicer
logged in my testing would be a timeout errors before this change (BTW, I wonder is AddBusStopName unreasonably expensive or is it just an unlucky call)