Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ask about name of tourism=chalet #1519

Merged
merged 1 commit into from Aug 14, 2019

Conversation

matkoniecz
Copy link
Member

@matkoniecz matkoniecz commented Aug 14, 2019


My work on this pull request was sponsored by a NGI Zero Discovery grant

@westnordost
Copy link
Member

I can think of examples where individual chalets do not have names: In accomodations that are essentially chalet complexes, the individual chalets may just have numbers, like room numbers. I'd expect those places usually be tagged as tourism=resort, but I am not sure if the definition of resort is so sound that it is always understood and used this way.

@matkoniecz
Copy link
Member Author

In accomodations that are essentially chalet complexes, the individual chalets may just have numbers, like room numbers.

In that case I would treat tagging individual buildings with tourism=* tags as incorrect in the same way as mapping each hotel room as tourism=apartment or each gas pump at petrol station as amenity=fuel.

@westnordost
Copy link
Member

You have a point. However, I am not even sure if tourism=resort is unmistakeably defined in the wiki (and used in practice) the way I interpret it to be, as a "collection of chalets".
So, this requires a bit of research.

@westnordost
Copy link
Member

Actually, I just found that "resort" is not only not what I thought it is, it is also deprecated. In South East Asia, there are many places calling themselves "resort" that are this kind of collection of chalets and/or apartments.
A few years back, I mapped this island:
https://www.openstreetmap.org/#map=17/11.81594/102.46438
and it turns out, I already used tourism=chalet for this kind anyway.

@westnordost
Copy link
Member

So, this PR is fine.

@westnordost westnordost merged commit ab28141 into streetcomplete:master Aug 14, 2019
@matkoniecz matkoniecz deleted the chalet_name branch November 15, 2019 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants