Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop duplicating office lists, use full list in each quest [ready for review] #1522

Merged
merged 3 commits into from Aug 19, 2019

Conversation

matkoniecz
Copy link
Member

No description provided.

@matkoniecz
Copy link
Member Author

lawyers are not really walk-in for customers, as much as an architect or other company providing a service (such as: building a table, building a smartphone app) aren't. They do work for clients, but the office hours are certainly not opening hours.

Example: White & Case (big law firm) lists no opening hours, only a phone number.

I have (fortunately) little experience here

Same with political parties, it is not really public in any sense. You can't simply walk in there, it is rather the point where the political party meets. Maybe they organize some public Q&A hours, maybe the don't.

It may be confusion of lumping together places with public outreach where one may meet representative of a politician or sometimes actually one of the politicians. Random example (top result of "biuro poselskie"): http://www.aleksandermrowczynski.org/biuro-poselskie/

But probably there are some handling internal stuff not open to public.

Not sure how this two types are distinguished in tagging (I posted question on tagging mailing list, I think that I would mark it with access tag).

Also, from my experience, therapists do not have a reception, thus, it's not walk-in and appointments are made via phone or internet.

I have also fortunately limited experience here but there are therapist offices with reception (but bigger ones like that are far more noticeable).

@matkoniecz
Copy link
Member Author

matkoniecz commented Aug 14, 2019

I will probably end with OFFICES_VISITED_BY_GENERAL_PUBLIC and OFFICES_WITH_WALK_IN_BY_GENERAL_PUBLIC to keep both office lists in the same place.

Yes, OFFICES_WITH_WALK_IN_BY_GENERAL_PUBLIC will be used once but it is worth reducing chance that lists will again diverge.

@westnordost
Copy link
Member

westnordost commented Aug 15, 2019 via email

@matkoniecz
Copy link
Member Author

matkoniecz commented Aug 18, 2019

After thinking over it again - in my opinion single use application-wide constant is weird, but worth keeping two very similar tag lists together.

@matkoniecz matkoniecz changed the title stop duplicating office lists, use full list in each quest stop duplicating office lists, use full list in each quest [ready for review] Aug 18, 2019
Co-Authored-By: Tobias Zwick <newton@westnordost.de>
@westnordost westnordost merged commit 51a32ec into streetcomplete:master Aug 19, 2019
@matkoniecz matkoniecz deleted the unify_offices branch September 18, 2019 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants