New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop duplicating office lists, use full list in each quest [ready for review] #1522
Conversation
app/src/main/java/de/westnordost/streetcomplete/data/meta/OsmTaggings.java
Show resolved
Hide resolved
I have (fortunately) little experience here
It may be confusion of lumping together places with public outreach where one may meet representative of a politician or sometimes actually one of the politicians. Random example (top result of "biuro poselskie"): http://www.aleksandermrowczynski.org/biuro-poselskie/ But probably there are some handling internal stuff not open to public. Not sure how this two types are distinguished in tagging (I posted question on tagging mailing list, I think that I would mark it with
I have also fortunately limited experience here but there are therapist offices with reception (but bigger ones like that are far more noticeable). |
I will probably end with Yes, |
Yeah but then putting it in an application wide constant is almost for naught
…On August 14, 2019 11:42:56 PM GMT+02:00, Mateusz Konieczny ***@***.***> wrote:
I will probably end with `OFFICES_VISITED_BY_GENERAL_PUBLIC` and
`OFFICES_WITH_WALK_IN_BY_GENERAL_PUBLIC` to keep both office lists in
the same place.
|
After thinking over it again - in my opinion single use application-wide constant is weird, but worth keeping two very similar tag lists together. |
app/src/main/java/de/westnordost/streetcomplete/data/meta/OsmTaggings.java
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tobias Zwick <newton@westnordost.de>
No description provided.