Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support popular craft values and more office values #1526

Merged
merged 5 commits into from Aug 21, 2019

Conversation

matkoniecz
Copy link
Member

fixes #1525

@westnordost
Copy link
Member

westnordost commented Aug 19, 2019

Why would painters, window construction workshops, caterers, hvac, blacksmiths, upholsterer etc. have no name? Summarizing:

  • if the place is open for walk-in by general public -> ask for opening hours
  • if the place is either the above or at least public in the frame of public events -> ask for wheelchair accessibility
  • if a place like this usually or at least sometimes has a name -> ask for a name

I don't think your categorization with the OsmTaggings works here. Probably, almost any "craft" thing will have a name. In the case of crafts, the list for opening hours and wheelchair accessibility should almost be the same.

@westnordost
Copy link
Member

Actually, it is the question whether not much more if not almost all office keys would usually have a name

@matkoniecz matkoniecz changed the title support popular craft values support popular craft values and more office values Aug 19, 2019
@matkoniecz
Copy link
Member Author

matkoniecz commented Aug 19, 2019

I pushed some commits, but are untested (and tag lists would benefit from fresh look)

"carpenter", "shoemaker", "tailor", "photographer", "dressmaker",
"electronics_repair", "key_cutter", "stonemason",
// also listed for AddPlaceName quest
"winery", "electrician", "plumber"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why you include plumber and electrician. Wouldn't you then also need to include hvac (etc etc)?

I decided to ask ask about office=yes and craft=yes
I admit that I have no idea why I added them
@matkoniecz
Copy link
Member Author

I am thinking about excluding shop/craft=vacant/no

This problem is basically not appearing for craft and quite rare for office so I decided to not include this checks.

@westnordost
Copy link
Member

Ok, looks good!

@westnordost westnordost merged commit 3b82890 into streetcomplete:master Aug 21, 2019
@matkoniecz matkoniecz deleted the craft branch August 21, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support craft=tailor and other craft=* for OH, wheelchair and name quests
2 participants