New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support popular craft values and more office values #1526
Conversation
Why would painters, window construction workshops, caterers, hvac, blacksmiths, upholsterer etc. have no name? Summarizing:
I don't think your categorization with the OsmTaggings works here. Probably, almost any "craft" thing will have a name. In the case of crafts, the list for opening hours and wheelchair accessibility should almost be the same. |
Actually, it is the question whether not much more if not almost all |
I pushed some commits, but are untested (and tag lists would benefit from fresh look) |
app/src/main/java/de/westnordost/streetcomplete/quests/place_name/AddPlaceName.kt
Show resolved
Hide resolved
"carpenter", "shoemaker", "tailor", "photographer", "dressmaker", | ||
"electronics_repair", "key_cutter", "stonemason", | ||
// also listed for AddPlaceName quest | ||
"winery", "electrician", "plumber" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why you include plumber and electrician. Wouldn't you then also need to include hvac (etc etc)?
I decided to ask ask about office=yes and craft=yes
I admit that I have no idea why I added them
I am thinking about excluding shop/craft=vacant/no This problem is basically not appearing for craft and quite rare for office so I decided to not include this checks. |
Ok, looks good! |
fixes #1525