Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction quest now has an option "exact date is known" fixes #1341 #2402

Merged
merged 8 commits into from
Dec 28, 2020

Conversation

matkoniecz
Copy link
Member

available via can't say menu, a bit hidden but as discussed in #1341
it is hard to find a better place for it

…etcomplete#1341

available via can't say menu, a bit hidden but as discussed in streetcomplete#1341
it is hard to find a better place for it
@matkoniecz matkoniecz changed the title Construction quest now has an option "exact date is known" fixes #1341 [WIP, comments welcomed] Construction quest now has an option "exact date is known" fixes #1341 Dec 22, 2020
@matkoniecz matkoniecz marked this pull request as ready for review December 22, 2020 14:02
@westnordost
Copy link
Member

You chose the "open"-wording. However, this may apply to roads and businesses, but you wouldn't be able to say that a "apartment building is open".

@matkoniecz
Copy link
Member Author

You chose the "open"-wording. However, this may apply to roads and businesses, but you wouldn't be able to say that a "apartment building is open".

OK, so I need to change it back. I basically learned about one more difference between Polish and English.

@westnordost
Copy link
Member

westnordost commented Dec 22, 2020

"apartment building is open" sounds to me like maybe it is "open" in the sense of that the roof is missing and thus at the top, it's open. ;-)

In German, you can say that a thing is "eröffnet" (=opened), but you can only say that for something public because it suggests that it is open for people to enter/use, i.e. also not for apartments.

@westnordost
Copy link
Member

Looks good now! Did you test it?

@matkoniecz
Copy link
Member Author

I changed again to "Will be finished at date…" to make clear that it is not about recording completion date that already happened.

I tested it, though I am running right now retest after all this text changes.

@matkoniecz
Copy link
Member Author

Still works, as expected.

@westnordost westnordost merged commit 026bfb1 into streetcomplete:master Dec 28, 2020
@matkoniecz matkoniecz deleted the calendar branch February 20, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants