Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember more building level quest answers #2925

Merged
merged 7 commits into from
Jun 7, 2021
Merged

Remember more building level quest answers #2925

merged 7 commits into from
Jun 7, 2021

Conversation

FloEdelmann
Copy link
Member

@FloEdelmann FloEdelmann commented May 28, 2021

Closes #1772.

Screenshots

First time opening the quest:
Unchanged interface.
One saved answer:
The button position changed.
Two saved answers:
The latest one is on the left.
After selecting a saved answer:
The buttons remain there.
When there is too little space:
The buttons can scroll horizontally. There are at most 5 saved answers.

@westnordost
Copy link
Member

Is the form always expanded already? Or do you have to pull it up?

@matkoniecz
Copy link
Member

Not tested yet, but I really like this idea.

@mnalis
Copy link
Member

mnalis commented May 31, 2021

Pictures look good to me, is there perhaps an .apk to try out?

@smichel17
Copy link
Member

Screenshots look good to me, my only concern is what happens when the OK button is visible and there are a lot of options.

I haven't tried it out yet but here's a debug apk: https://smichel.me/files/streetcomplete/streetcomplete-debug-09629c77.apk

@FloEdelmann
Copy link
Member Author

FloEdelmann commented Jun 2, 2021

@westnordost The form is always expanded already.

@smichel17 The OK button does not overlap the prefill buttons, so I think that mis-tapping is not a big concern:

Screenshot

Thanks for creating the debug apk!

@mnalis
Copy link
Member

mnalis commented Jun 2, 2021

@smichel17 thanks for debug version.

@FloEdelmann it feels pretty nice, good work!

Only issue I see, is that on my test phone (Xiaomi Redmi Note 3 Pro) there seems to be missing little space to show all 6 single-digit buildings (only 5 and a half fit on screen).

Purely cosmetic, but maybe icons can be squeezed a little so all 6 last buildings fit on screen (if they are all single-digit levels)? Or if there is not enough space for that, maybe even drop to showing last 5 buildings?

levels1

@westnordost
Copy link
Member

I think 5 would be enough

@westnordost westnordost merged commit 845f11d into streetcomplete:master Jun 7, 2021
@FloEdelmann FloEdelmann deleted the remember-more-building-levels branch June 7, 2021 17:44
@matkoniecz
Copy link
Member

I tested it today and it works great!

Maybe making clear that this things at the bottom are clickable buttons may be nice. Borders?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it faster to answer the building levels quest
5 participants