-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember more building level quest answers #2925
Remember more building level quest answers #2925
Conversation
Is the form always expanded already? Or do you have to pull it up? |
Not tested yet, but I really like this idea. |
Pictures look good to me, is there perhaps an |
Screenshots look good to me, my only concern is what happens when the OK button is visible and there are a lot of options. I haven't tried it out yet but here's a debug apk: https://smichel.me/files/streetcomplete/streetcomplete-debug-09629c77.apk |
@westnordost The form is always expanded already. @smichel17 The OK button does not overlap the prefill buttons, so I think that mis-tapping is not a big concern: Thanks for creating the debug apk! |
@smichel17 thanks for debug version. @FloEdelmann it feels pretty nice, good work! Only issue I see, is that on my test phone (Xiaomi Redmi Note 3 Pro) there seems to be missing little space to show all 6 single-digit buildings (only 5 and a half fit on screen). Purely cosmetic, but maybe icons can be squeezed a little so all 6 last buildings fit on screen (if they are all single-digit levels)? Or if there is not enough space for that, maybe even drop to showing last 5 buildings? |
I think 5 would be enough |
app/src/main/java/de/westnordost/streetcomplete/quests/building_levels/BuildingLevelsAnswer.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/building_levels/AddBuildingLevelsForm.kt
Outdated
Show resolved
Hide resolved
I tested it today and it works great! Maybe making clear that this things at the bottom are clickable buttons may be nice. Borders? |
Closes #1772.
Screenshots
Unchanged interface.
The button position changed.
The latest one is on the left.
The buttons remain there.
The buttons can scroll horizontally. There are at most 5 saved answers.