Add "office" to buildings allowed to have a housenumber

[yrtimiD]

Minor change. From my experience office buildings always have an address.

[matkoniecz]

Good idea! Have you tested this change? It is trivial, it looks right but...

Just to check: https://github.com/streetcomplete/StreetComplete/pulls?q=office+address - seems to not be rejected earlier

[yrtimiD]

Have you tested this change? It is trivial, it looks right but...
Sincerely saying - no. Overhead of installing android studio for such a minor change is pretty big, and I'll be very surprised if something will fail in this case :) But, of course, I can test it, if you insist.
Any chance you have any external builder which can produce an apk from specific branch?

[matkoniecz]

No, in such case I will simply test it. Sadly setting up Android Studio is quite obnoxious and I am not aware about some easy to use builder

[smichel17]

There is an easy-to-use external builder called @smichel17 :)

https://smichel.me/files/streetcomplete/streetcomplete-debug-daac414.apk

[matkoniecz]

tested (there is always tiny chance of for example invisible character lurking somewhere) - and it works nicely. Thank you for the contribution!

[smichel17]

I'm very sympathetic to the setup issue.

I've been putting off https://gitlab.com/fdroid/fdroidserver/-/issues/829 for almost a year now because every month or two when I find myself with both the time and motivation to work on it, getting a good python dev environment set up saps all my motivation, and then by the next time I've forgotten what I needed to do to get there. To the point where I bought some additional ram so I can just do it in a Debian vm and install everything globally so I don't have to worry about virtualenv crap. /rant

If you want to do more SC dev, ping me and I'm happy to walk you through whatever setup is needed (imo Android Studio installation is relatively easy, but if you prefer to work in the terminal, installing the standalone Android SDK is not). One of these days, someone will get the dev tools setup experience right…

[yrtimiD]

@smichel17 , thanks!
Meanwhile I'm trying to setup github actions for the build only (despite some failed tries I found), I believe this way is a most convenient for contributors who want to do a fast fix.

[mnalis]

@yrtimiD For me, I just added .github/workflows/build.yml to my fork, and then Github builds debug .apk for me (you can run it manually in the Actions github tab, or automatically on pull), which I just download and install manually to test changes.

[yrtimiD]

@mnalis, right, eventually, this was an easies way to get debug apk, just took me some time to prepare it first time.
FYI, now actions/workflows/build-debug-apk is available on upstream too, so no need to mess with this each time.

[smichel17]

I tried it, then canceled it, and it sent me an email about the cancellation. Sorry if I spammed anyone else.