hint that all users should enable team mode #3170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some actual people were confused about that closes streetcomplete#2741 that proposed to add more info about this
|
@FloEdelmann mentioned the original wording before I changed it #2741 (comment). I don't remember why I changed it and I did not see any post where I explained it, so I guess it wasn't about what this PR re-adds but maybe just the wording. So from my view, this is good to merge. |
westnordost
approved these changes
Aug 16, 2021
FloEdelmann
approved these changes
Aug 16, 2021
smichel17
requested changes
Aug 16, 2021
There was a problem hiding this comment.
Aah, I'm too late. But, I would do it like this:
- Change the
team_mode_team_size_labelstring to "How many people are there? Each person in the group must enter this number on their phone." - The suggested change below
That way the concept that everyone is doing it on their own phone is introduced earlier, and stays on screen the whole time. And then it's also clear that the second instruction is just for you.
| @@ -870,7 +870,7 @@ Otherwise, you can download another keyboard in the app store. Popular keyboards | |||
| <string name="team_mode_description">When mapping the same area together in a group, you can enter team mode to split up quests between all team members.</string> | |||
| <string name="team_mode_team_size_label">How many people are there?</string> | |||
| <string name="team_mode_team_size_hint">Team mode works for groups of 2 to 12 people.</string> | |||
| <string name="team_mode_choose_color">Now everybody in your group chooses a unique color:</string> | |||
| <string name="team_mode_choose_color2">Now everybody in your group chooses a unique color on their phone:</string> | |||
There was a problem hiding this comment.
Suggested change
| <string name="team_mode_choose_color2">Now everybody in your group chooses a unique color on their phone:</string> | |
| <string name="team_mode_choose_color2">Next, everybody must pick a different color. Choose yours:</string> |
|
I can't reopen a PR, could you maybe create a new PR for that? Then we can also see the big picture. |
|
Done, #3172 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some actual people were confused about that
closes #2741 that proposed to add more info about this