Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Survey invalid cycleway #3206

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Survey invalid cycleway #3206

merged 5 commits into from
Aug 25, 2021

Conversation

westnordost
Copy link
Member

Fixes #3148

@westnordost westnordost mentioned this pull request Aug 22, 2021
Closed
peternewman
peternewman reviewed Aug 23, 2021
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of very minor comments

app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Outdated Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Outdated Show resolved Hide resolved
@peternewman peternewman mentioned this pull request Aug 23, 2021
Closed
westnordost and others added 2 commits August 23, 2021 23:27
@westnordost @peternewman
Update app/src/main/java/de/westnordost/streetcomplete/quests/cyclewa…
19bf3a9 
…y/AddCycleway.kt

Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
@westnordost @peternewman
Update app/src/main/java/de/westnordost/streetcomplete/quests/cyclewa…
7391ca8 
…y/AddCycleway.kt

Co-authored-by: Peter Newman <peternewman@users.noreply.github.com>
@westnordost
Copy link
Member Author

Thank you, @peternewman !

peternewman
peternewman reviewed Aug 24, 2021
View reviewed changes
Copy link
Collaborator

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more minor comments.

app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Show resolved Hide resolved
@westnordost
Copy link
Member Author

Thanks for the review, @peternewman !

@westnordost westnordost merged commit 02556df into master Aug 25, 2021
@westnordost westnordost deleted the survey-invalid-cycleway branch August 25, 2021 11:26
smichel17
smichel17 reviewed Aug 25, 2021
View reviewed changes
Copy link
Member

@smichel17 smichel17 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit late to the party, but I started looking at this before you merged, so I figured I may as well finish.

app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/Cycleway.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/AddCycleway.kt Show resolved Hide resolved
app/src/main/java/de/westnordost/streetcomplete/quests/cycleway/Cycleway.kt Show resolved Hide resolved
@westnordost
Copy link
Member Author

Thank you for the review!

@Helium314 Helium314 mentioned this pull request Sep 17, 2021
Closed
@peternewman peternewman mentioned this pull request Oct 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternewman peternewman peternewman left review comments

@smichel17 smichel17 smichel17 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Immediately resurvey any incomplete cycleway tagging
3 participants
@westnordost @peternewman @smichel17