Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add fire hydrant position quest #3368

Merged
merged 19 commits into from Dec 30, 2021
Merged

add fire hydrant position quest #3368

merged 19 commits into from Dec 30, 2021

Conversation

thefeiter
Copy link
Contributor

@thefeiter thefeiter commented Oct 11, 2021 •
edited

So far it should be already quite usable. I used the fire_hydrant:type quest as a template and changed imaged and strings.

The tag used by this quest is fire_hydrant:position (wiki, under optional tags)
This Could be useful to find a hydrant faster and is a fast to answer quest.

I just need an image for the "parking_lot" position.

@thefeiter thefeiter changed the title add fire hydrant position quest [WIP] add fire hydrant position quest Oct 11, 2021
@westnordost
Copy link
Member

Thank you again for your work. But please before you continue, we need to determine if collecting this information satisfies the quest guidelines.

In particular, where is this key documented? What sense does it make to record this information?

@westnordost westnordost added the feedback required more info is needed, issue will be likely closed if it is not provided label Oct 11, 2021
@thefeiter
Copy link
Contributor Author

updated description

@matkoniecz
Copy link
Member

It seems to me fire_hydrant:position should be mapped by locating hydrant node at the exact position where it is located, like any other objects. And mapping surrounding of fire hydrant is best done by, well, mapping surroundings of hydrant rather describing them as a special tag.

@thefeiter
Copy link
Contributor Author

Kind of. If you seach for a hydrant (assuming a firefighter or else) and you have reached the rough coordinate of the node and you now search for the hydrant it might be useful to know were it is located. If you see, it is located on the street you will find it much faster, since you only have too look on the street.
In my village, when tagging hydrants I had to seach for one quite some time, since it is hidden next to the sidewalk in a grass patch (which is not directly mapped itself). If i knew it was locaded on grass I would have been able to find it much faster.

Mapping the surounding grass patch would take much longer than just adding the position key.

@westnordost
Copy link
Member

Hmm, is there no dedicated documentation for the key? Where did you get the pictures from? Did you make them yourself? There is a authors.txt also in the /res/ directory, you can add the author + license there.

Maybe if you created them yourself, you also want to add them to the wiki and properly document the tag as it is used?

@westnordost
Copy link
Member

ping

@thefeiter
Copy link
Contributor Author

thefeiter commented Nov 17, 2021 via email

@thefeiter
Copy link
Contributor Author

Now the Tags are properly documented in the wiki along with pictures

@thefeiter
Copy link
Contributor Author

thefeiter commented Dec 28, 2021 •
edited

photo_2021-12-28_21-07-46

One could try to find a better image for the lane option, but this is not easy since if you crop to the hydrant, it is no longer recognizable as a lane.

@smichel17
Copy link
Member

Nice!

I think that type of image is fine for the lane. However, it should be more centered-- that particular image has the hydrant so close to the bottom that it is partially covered by the text!

For phrasing:

  • "On the side of a road lane" -- is side relevant for the tagging? If not, I'd shorten it to one of: "In the lane of a road" or "In a travel lane" (depending on how obvious the road part is from the picture).

  • "In a parking" -- needs a word added to the end. Probably one of these, depending on your desired meaning: spot, space, lane, area.

  • The other two are good.

@thefeiter
Copy link
Contributor Author

  • "On the side of a road lane" -- is side relevant for the tagging? If not, I'd shorten it to one of: "In the lane of a road" or "In a travel lane" (depending on how obvious the road part is from the picture).

What about just "On a road" ?
I just mapped some hydrants and this seems to be just fine.

@westnordost
Copy link
Member

Better wordings are IMO:

  • On the roadway
  • On the sidewalk
  • In grass or dirt
  • In a parking

@thefeiter
Copy link
Contributor Author

I also took some new pictures:

https://commons.wikimedia.org/wiki/File:Fire_hydrant_on_road_side.jpg
https://commons.wikimedia.org/wiki/File:Fire_hydrant_on_sidewalk_2.jpg

What do you think about using these?

@thefeiter
Copy link
Contributor Author

  • In a parking

Are you sure, that "In a parking area" wouldn't be better?

@westnordost
Copy link
Member

I don't know

@smichel17
Copy link
Member

smichel17 commented Dec 29, 2021 •
edited

"In a parking" sounds awkward, similar to this:

✔️ "It is for parking"
❌ "It is a for parking".

Unfortunately, I am not sure exactly how the grammar works here 😬. Going by "it sounds right", the only two situations that I can think of off hand where "parking" stands alone as a noun are "What type of parking is this?" and "Where is the parking [for this store]?" (bracketed part sometimes implied rather than spoken). Otherwise, it is an adjective and thus needs a noun to go with it (spot, space, lane, area…).

"Area" is the most broad. I would prefer a more specific word, but only if it is correct.

@thefeiter @FloEdelmann
Update app/src/main/java/de/westnordost/streetcomplete/quests/fire_hy…
ad500cf 
…drant/AddFireHydrantPosition.kt


well, yep

Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
@westnordost westnordost changed the title [WIP] add fire hydrant position quest add fire hydrant position quest Dec 29, 2021
@westnordost westnordost removed the feedback required more info is needed, issue will be likely closed if it is not provided label Dec 29, 2021
FloEdelmann
FloEdelmann approved these changes Dec 29, 2021
View reviewed changes
Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

westnordost
westnordost reviewed Dec 30, 2021
View reviewed changes
Copy link
Member

@westnordost westnordost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, one more thing: I noticed that the pictures seem to be very large, both in file size and in pixel size.

The pictures have a size of 384x384 dp. That is as large as they'd need to be if each picture should cover the whole form in width. So actually, they can be half the size:

mdpi: 192x192
hdpi: 288x288
xhdpi: 384x384
xxhdpi: 576x576

Also note that the JPEG quality doesn't need to be 90, depending on the image displayed, it can be lower without visible artifacts. (When saving with GIMP, you can compare how the image would look by adjusting the slider.)

@westnordost
Copy link
Member

👍

@westnordost westnordost merged commit 553fc38 into streetcomplete:master Dec 30, 2021
@westnordost
Copy link
Member

I wonder, would it make sense to do the same improvement for this quest as done in #3608 ?

@thefeiter
Copy link
Contributor Author

thefeiter commented Dec 30, 2021 •
edited

That's a good Idea. I would say this is another task for @tiptoptom...

@westnordost
Copy link
Member

Why tiptoptom?

@thefeiter
Copy link
Contributor Author

thefeiter commented Dec 31, 2021 via email

@tiptoptom
Copy link
Contributor

tiptoptom commented Dec 31, 2021 •
edited

But I had a lot of help from @thefeiter 😁🙈

@matkoniecz
Copy link
Member

It would be preferable to mention authors in res/graphics/authors.txt

Note that link is present but file may be deleted/moved/renamed in the future and the license requires attribution.

Also, the license info likely should be in https://github.com/streetcomplete/StreetComplete/blob/bb71ae91976ce4f16c22c7ce09ecdcc388a649e1/app/src/main/res/authors.txt

@thefeiter
Copy link
Contributor Author

Do you mean the authors of the images?
I took 3/4 of them, so I could modify res/graphics/authors.txt to:

fire hydrant position graphics/
    Fire_hydrant_in_grass.jpg                   Marvin Feiter https://upload.wikimedia.org/wikipedia/commons/2/2d/Fire_hydrant_in_grass.jpg (CC BY-SA 4.0)
    Fire_hydrant_on_sidewalk.jpg                Marvin Feiter https://upload.wikimedia.org/wikipedia/commons/3/32/Fire_hydrant_on_sidewalk.jpg (CC BY-SA 4.0)
    Fire_hydrant_lane.jpg                       Marvin Feiter modified from https://upload.wikimedia.org/wikipedia/commons/d/d0/Fire_hydrant_on_road_side.jpg (CC BY-SA 4.0)
    Fire_hydrant_parking.jpg                    centauri modified from https://upload.wikimedia.org/wikipedia/commons/3/33/Fire-fighting-facility_node-4279866277.jpg (CC BY 2.0)

And also add this to the file you mentioned? Is that what you mean?

@westnordost
Copy link
Member

Already moved the attribution to the other authors.txt

@tiptoptom
Copy link
Contributor

Am I right that the Position quest does not currently show neighboring hydrants like the other hydrant quests?

@matkoniecz
Copy link
Member

@tiptoptom Good point, changed: 1d809c1

@mpawelski
Copy link

This is great addition. I just notices this new quest and went on to fill it in my neighborhood and want to share my experience. Luckily my thirst three hydrants were in three different places (green, sidewalk, parking_lot) and they were fire_hydrant:type=underground so the experience was great.

But then I found some hydrants of type fire_hydrant:type=pillar and got confused. Because what I saw in front of me was this:
image
but in app I saw this:
image

And I just decided to skip this quest because of confusion, I saw different type of hydrant in real life and different in app's images.

I know that the question is about hydrant position, and I later checked that this hydrant was indeed tagged correctly as fire_hydrant:type=pillar so I should just choose grass. But maybe we can think about showing different pictures if hydrant is indeed tagged as fire_hydrant:type=pillar? StreetComplete is great because of its UX and use of good pictures to ask question. I think this would be small nice UX improvement for average user.

@westnordost
Copy link
Member

Hm, I suppose this would be an improvement. Pillar hydrants are probably also never in parkings and never on the street surface, so for pillar hydrants, it could be just two images.
Would you create a new issue with this request? Maybe you could also look for freely licensed (or make yourself) pictures of pillar hydrants in the grass/dirt and pillar hydrants on the sidewalk.

@FloEdelmann
Copy link
Member

never on the street surface

Maybe on streets that don't have a sidewalk, a pillar hydrant may be located on one side of the road?

@westnordost
Copy link
Member

westnordost commented Jan 28, 2022 via email

@FloEdelmann FloEdelmann mentioned this pull request Jan 28, 2022
Closed
@smichel17
Copy link
Member

smichel17 commented Jan 28, 2022 via email •
edited

@FloEdelmann
Copy link
Member

@smichel17 See #3686: I already found one (via Wikimedia Commons): https://commons.wikimedia.org/wiki/File:Fire-fighting-facility_node-6464454770.jpg

The OSM node (https://www.openstreetmap.org/node/6464454770) is tagged fire_hydrant:position=lane.

@mnalis
Copy link
Member

mnalis commented Jan 28, 2022 •
edited

Hm, I suppose this would be an improvement. Pillar hydrants are probably also never in parkings and never on the street surface, so for pillar hydrants, it could be just two images.

Actually surprising percentage of pillars so far (I've just started mapping those, though) for me seems to be on parking lots (although I wholeheartedly agree that is probably not very smart idea - but it does not look like particularly good idea for underground ones either). Eg. https://www.openstreetmap.org/node/3423554061 and https://www.openstreetmap.org/node/3423477857 just the other day. (Obviously it is at the far end of parking or between parking places).

I can go take picture of that one if wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost approved these changes

@FloEdelmann FloEdelmann FloEdelmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@thefeiter @westnordost @matkoniecz @smichel17 @tiptoptom @mpawelski @FloEdelmann @mnalis