Add other answer "not a bollard" to bollard type quest #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was about to ask in what situation another barrier would be mistagged as a bollard, but it looks like according to #3817, this happens to quite often. So, thanks for implementing! |
westnordost
approved these changes
Mar 6, 2022
app/src/main/java/de/westnordost/streetcomplete/quests/bollard_type/AddBollardType.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users chooses "other answers" and "not a bollard", the former
barrier=bollardis instead retagged withbarrier=yes, so regularbarrier typequest can pop up.(Implemented in mostly the same way as
bench_backrestquest withit's a picnic tableanswer.)Tested and it seems to work correctly.
Closes #3817