Smoking outside tuning

[mnalis]

This PR tries to address superfluous OUTSIDE answer when it should be hidden, as reported in #3856

• do not show quest at all if there are neither indoor nor outdoor seating (nor smoking area)
• hide OUTSIDE answer if it is known that there is no smoking possible outside (no outside seating, and no standing smoking area like in nightclub)

[peternewman]

* hide `OUTSIDE` answer if it is known that there is no outside seating

In the UK at least it's quite common, particular outside nightclubs, to have a small fenced area where people can smoke without having to leave the area the club controls (and pay for a new ticket etc). This fenced area is often on the pavement and may not have seating, which might break your current logic here.

See some average to rubbish photos of the like here:
https://www.vice.com/en/article/z3xwa4/this-is-what-englands-nightclub-smoking-areas-looked-like-last-night

[mnalis]

In the UK at least it's quite common, particular outside nightclubs, to have a small fenced area where people can smoke without having to leave the area the club controls

thanks @peternewman that is quite informative! I'm now undecided, should I just add the exception for nightclub (and likely stripclub as it might behave similarly?), or do pubs/cafes/restaurants also might have such arrangements and I should thus show OUTSIDE answer regardless of outdoor_seating=no ?

[peternewman]

thanks @peternewman that is quite informative! I'm now undecided, should I just add the exception for nightclub (and likely stripclub as it might behave similarly?), or do pubs/cafes/restaurants also might have such arrangements and I should thus show OUTSIDE answer regardless of outdoor_seating=no ?

Maybe pubs too as it might apply to some of the more clubby/youth ones, its more about having to queue for entry, possibly pay and/or have ID checks.

I don't think cafes or restaurants will have the queue/pay/ID issues, so probably won't bother. They're also more likely (possibly along with some pubs) to have outdoor seating at which point that bit kicks in too.

[mnalis]

When you work it out, it would be good to add some tests for that (if they don't exist already), to ensure it continues to behave in the same way in case this or something else is making use of that behaviour.

I've created app/src/test/java/de/westnordost/streetcomplete/quests/smoking/AddSmokingTest.kt and tried to put some checks there. What else is needed so that those tests are checked? Are the checks run automatically when package is being built when click on .github/workflows/build-debug-apk.yml GitHub actions or do something special needs to be done?

[mnalis]

Thanks for suggestions, @FloEdelmann! Do you know how/when those tests are actually run?
I'd like to run them to verify it it works as intended, before moving this out of draft.

[FloEdelmann]

The tests are not run at all on GitHub Actions, they have to be run locally: Either via Android Studio, or in the commandline:

./gradlew :app:cleanTestDebugUnitTest :app:testDebugUnitTest --tests "de.westnordost.streetcomplete.*"

[mnalis]

Thanks @FloEdelmann , I've added that command (in my fork GitHub workflow) to run tests, and it passes the checks now.

One more question: do you know if it is possible to check whether some option is shown in the list of answers or not?

Smoking quest sometimes offers OUTSIDE answer (and sometimes not) depending on various conditions (i.e. https://github.com/mnalis/StreetComplete/blob/smoking-outside-fix/app/src/main/java/de/westnordost/streetcomplete/quests/smoking/SmokingAllowedAnswerForm.kt#L25), so I'd like to check that too if it is (easily) possible.

[FloEdelmann]

do you know if it is possible to check whether some option is shown in the list of answers or not?

Unfortunately, I don't know if that's possible here. Maybe only in the instrumented tests that have access to the Android runtime.

[mnalis]

Thanks @FloEdelmann, I though that it might be more complicated... Then this is ready for review.

[westnordost]

Looks good!